Use Drupal coding standards. Phpcs report:
FILE: ...google_analytics_counter/css/google_analytics_counter.module.css
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
21 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...tics_counter/src/Controller/GoogleAnalyticsCounterController.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
20 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
52 | WARNING | [ ] Line exceeds 80 characters; contains 81
| | characters
185 | ERROR | [x] Concat operator must be surrounded by a single
| | space
185 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
197 | WARNING | [ ] Line exceeds 80 characters; contains 82
| | characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...oogle_analytics_counter/src/GoogleAnalyticsCounterAppManager.php
----------------------------------------------------------------------
FOUND 35 ERRORS AND 13 WARNINGS AFFECTING 36 LINES
----------------------------------------------------------------------
20 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
123 | ERROR | [x] Expected 1 blank line before function; 2 found
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
124 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
150 | ERROR | [x] Parameter comment must end with a full stop
160 | ERROR | [ ] Type hint "array" missing for $parameters
160 | ERROR | [ ] Type hint "array" missing for $cache_options
200 | ERROR | [x] No space found before comment text; expected "//
| | Instantiate a new GoogleAnalyticsCounterFeed
| | object." but found "//Instantiate a new
| | GoogleAnalyticsCounterFeed object."
203 | WARNING | [ ] Line exceeds 80 characters; contains 86
| | characters
206 | WARNING | [ ] Line exceeds 80 characters; contains 88
| | characters
211 | WARNING | [ ] Line exceeds 80 characters; contains 82
| | characters
214 | WARNING | [ ] Line exceeds 80 characters; contains 82
| | characters
217 | WARNING | [ ] Line exceeds 80 characters; contains 82
| | characters
233 | ERROR | [ ] sizeof() is a function name alias, use count()
| | instead
235 | ERROR | [ ] sizeof() is a function name alias, use count()
| | instead
259 | ERROR | [x] Parameter comment indentation must be 3 spaces,
| | found 1 spaces
267 | WARNING | [ ] Line exceeds 80 characters; contains 83
| | characters
268 | WARNING | [ ] Line exceeds 80 characters; contains 89
| | characters
270 | ERROR | [x] Expected one space after the comma, 0 found
270 | ERROR | [x] Expected one space after the comma, 0 found
289 | ERROR | [x] Expected "int" but found "integer" for parameter
| | type
317 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, question marks, colons, or
| | closing parentheses
331 | ERROR | [ ] Missing parameter comment
331 | ERROR | [ ] Missing parameter type
332 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
337 | WARNING | [ ] Line exceeds 80 characters; contains 85
| | characters
379 | WARNING | [ ] Line exceeds 80 characters; contains 92
| | characters
379 | WARNING | [x] 'Todo: This can be more performant by adding
| | only the bundles that have been selected.'
| | should match the format '@todo Fix problem X
| | here.'
382 | ERROR | [ ] The array declaration extends to column 125 (the
| | limit is 80). The array content should be split
| | up over multiple lines
398 | ERROR | [ ] Missing parameter comment
399 | ERROR | [ ] Missing parameter comment
401 | ERROR | [ ] Description for the @return value is missing
404 | ERROR | [x] No space found before comment text; expected "//
| | Instantiate a new GoogleAnalyticsCounterFeed
| | object." but found "//Instantiate a new
| | GoogleAnalyticsCounterFeed object."
428 | ERROR | [ ] Doc comment is empty
430 | ERROR | [ ] Doc comment is empty
451 | ERROR | [x] Use "elseif" in place of "else if"
452 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
460 | ERROR | [x] No space found before comment text; expected "//
| | It's a path." but found "//It's a path."
463 | WARNING | [x] 'todo: The array is an accommodation to
| | sumPageViews()' should match the format '@todo
| | Fix problem X here.'
465 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, question marks, colons, or
| | closing parentheses
467 | WARNING | [x] There must be no blank line following an inline
| | comment
467 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, question marks, colons, or
| | closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...e_analytics_counter/src/GoogleAnalyticsCounterMessageManager.php
----------------------------------------------------------------------
FOUND 15 ERRORS AND 7 WARNINGS AFFECTING 17 LINES
----------------------------------------------------------------------
67 | ERROR | [x] Doc comment short description must be on the
| | first line
94 | ERROR | [ ] Missing parameter comment
94 | ERROR | [ ] Missing parameter type
96 | ERROR | [x] Additional blank lines found at end of doc
| | comment
112 | ERROR | [ ] Missing parameter comment
112 | ERROR | [ ] Missing parameter type
113 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
113 | ERROR | [ ] Description for the @return value is missing
152 | ERROR | [ ] Description for the @return value must be on the
| | next line
172 | ERROR | [ ] Description for the @return value is missing
190 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
201 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
212 | ERROR | [ ] Missing parameter comment
212 | ERROR | [ ] Missing parameter type
214 | ERROR | [ ] Description for the @return value is missing
227 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
227 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
229 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
232 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
234 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
235 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
237 | WARNING | [ ] Avoid backslash escaping in translatable strings
| | when possible, use "" quotes instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ..._analytics_counter/src/Form/GoogleAnalyticsCounterRevokeForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
14 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
21 | ERROR | [x] Expected 1 blank line before function; 2 found
50 | WARNING | [x] 'todo: Send the user back to the form from which
| | he came.' should match the format '@todo Fix
| | problem X here.'
50 | ERROR | [ ] Unnecessarily gendered language in a comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...cs_counter/src/Form/GoogleAnalyticsCounterConfigureTypesForm.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
14 | WARNING | [ ] Line exceeds 80 characters; contains 85
| | characters
91 | WARNING | [ ] Line exceeds 80 characters; contains 94
| | characters
148 | WARNING | [ ] Line exceeds 80 characters; contains 83
| | characters
163 | ERROR | [x] Use "elseif" in place of "else if"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...le_analytics_counter/src/Form/GoogleAnalyticsCounterAuthForm.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
20 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
122 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
| | found 8
129 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
| | found 8
134 | ERROR | [x] Use "elseif" in place of "else if"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...nalytics_counter/src/Form/GoogleAnalyticsCounterSettingsForm.php
----------------------------------------------------------------------
FOUND 7 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
21 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
169 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
170 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
170 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
170 | ERROR | [x] Concat operator must be surrounded by a single
| | space
170 | ERROR | [x] Concat operator must be surrounded by a single
| | space
200 | WARNING | [ ] Translatable strings must not begin or end with
| | white spaces, use placeholders with t() for
| | variables
279 | WARNING | [ ] Only string literals should be passed to t()
| | where possible
287 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
287 | ERROR | [ ] Missing parameter comment
289 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ytics_counter/src/GoogleAnalyticsCounterCustomFieldGenerator.php
----------------------------------------------------------------------
FOUND 24 ERRORS AND 3 WARNINGS AFFECTING 21 LINES
----------------------------------------------------------------------
80 | ERROR | [ ] Doc comment is empty
82 | ERROR | [ ] Doc comment is empty
87 | ERROR | [ ] Missing parameter comment
87 | ERROR | [ ] Missing parameter type
88 | ERROR | [ ] Missing parameter comment
88 | ERROR | [ ] Missing parameter type
89 | ERROR | [ ] Missing parameter comment
89 | ERROR | [ ] Missing parameter type
115 | ERROR | [ ] Description for the @return value is missing
116 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
125 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, question marks, colons, or
| | closing parentheses
130 | WARNING | [ ] Line exceeds 80 characters; contains 81
| | characters
147 | ERROR | [x] Short array syntax must be used to define arrays
154 | ERROR | [x] Short array syntax must be used to define arrays
165 | ERROR | [x] Short array syntax must be used to define arrays
177 | ERROR | [x] Short array syntax must be used to define arrays
191 | ERROR | [ ] Missing parameter comment
191 | ERROR | [ ] Missing parameter type
192 | ERROR | [ ] Missing parameter comment
192 | ERROR | [ ] Missing parameter type
198 | WARNING | [x] 'Todo: Remove this method.' should match the
| | format '@todo Fix problem X here.'
208 | ERROR | [ ] Description for the @return value is missing
209 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
227 | ERROR | [ ] @return doc comment specified, but function has
| | no return statement
227 | ERROR | [ ] Description for the @return value is missing
228 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
240 | WARNING | [ ] Line exceeds 80 characters; contains 81
| | characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...cs_counter/src/GoogleAnalyticsCounterMessageManagerInterface.php
----------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 10 LINES
----------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace
| | declaration
16 | ERROR | [ ] Missing parameter comment
16 | ERROR | [ ] Missing parameter type
18 | ERROR | [x] Additional blank lines found at end of doc comment
24 | ERROR | [ ] Missing parameter comment
24 | ERROR | [ ] Missing parameter type
26 | ERROR | [ ] Description for the @return value is missing
44 | ERROR | [ ] Description for the @return value must be on the
| | next line
54 | ERROR | [ ] Description for the @return value is missing
61 | ERROR | [ ] Missing parameter comment
61 | ERROR | [ ] Missing parameter type
63 | ERROR | [ ] Description for the @return value is missing
74 | ERROR | [x] Expected 1 newline at end of file; 0 found
74 | ERROR | [x] The closing brace for the interface must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ogle_analytics_counter/src/GoogleAnalyticsCounterAuthManager.php
----------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
10 | ERROR | [x] Non-namespaced classes/interfaces/traits should
| | not be referenced with use statements
79 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
79 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
79 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
79 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
168 | WARNING | [ ] Line exceeds 80 characters; contains 89
| | characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...trib/google_analytics_counter/src/GoogleAnalyticsCounterFeed.php
----------------------------------------------------------------------
FOUND 54 ERRORS AND 2 WARNINGS AFFECTING 34 LINES
----------------------------------------------------------------------
158 | ERROR | [ ] Missing parameter comment
160 | ERROR | [ ] Type hint "null" missing for $refresh_token
258 | ERROR | [x] Expected "string|null" but found "string|NULL"
| | for parameter type
312 | ERROR | [ ] Missing parameter comment
312 | ERROR | [ ] Missing parameter type
321 | ERROR | [ ] Missing parameter comment
321 | ERROR | [ ] Missing parameter type
330 | ERROR | [ ] Missing parameter comment
330 | ERROR | [ ] Missing parameter type
331 | ERROR | [ ] Missing parameter comment
331 | ERROR | [ ] Missing parameter type
332 | ERROR | [ ] Missing parameter comment
332 | ERROR | [ ] Missing parameter type
333 | ERROR | [ ] Missing parameter comment
333 | ERROR | [ ] Missing parameter type
334 | ERROR | [ ] Missing parameter comment
336 | ERROR | [ ] Description for the @return value is missing
337 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
339 | ERROR | [ ] Type hint "array" missing for $cache_options
339 | ERROR | [x] Short array syntax must be used to define arrays
357 | ERROR | [x] Array indentation error, expected 8 spaces but
| | found 10
358 | ERROR | [x] Array indentation error, expected 8 spaces but
| | found 10
359 | ERROR | [x] Array closing indentation error, expected 6
| | spaces but found 8
395 | ERROR | [ ] Description for the @return value is missing
396 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
398 | ERROR | [ ] Type hint "array" missing for $params
398 | ERROR | [ ] Type hint "array" missing for $headers
398 | ERROR | [x] Short array syntax must be used to define arrays
398 | ERROR | [x] Short array syntax must be used to define arrays
425 | WARNING | [x] 'Todo: In that case, make drush fail more
| | elegantly.' should match the format '@todo Fix
| | problem X here.'
455 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
457 | ERROR | [ ] Type hint "array" missing for $params
457 | ERROR | [ ] Type hint "array" missing for $cache_options
457 | ERROR | [x] Short array syntax must be used to define arrays
457 | ERROR | [x] Short array syntax must be used to define arrays
472 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
474 | ERROR | [ ] Type hint "array" missing for $params
474 | ERROR | [ ] Type hint "array" missing for $cache_options
474 | ERROR | [x] Short array syntax must be used to define arrays
474 | ERROR | [x] Short array syntax must be used to define arrays
486 | ERROR | [x] Short array syntax must be used to define arrays
486 | ERROR | [x] Short array syntax must be used to define arrays
502 | ERROR | [x] Short array syntax must be used to define arrays
502 | ERROR | [x] Short array syntax must be used to define arrays
513 | ERROR | [ ] Missing parameter comment
514 | ERROR | [ ] Missing parameter comment
517 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
519 | ERROR | [ ] Type hint "array" missing for $params
519 | ERROR | [ ] Type hint "array" missing for $cache_options
519 | ERROR | [x] Short array syntax must be used to define arrays
519 | ERROR | [x] Short array syntax must be used to define arrays
539 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
541 | ERROR | [ ] Type hint "array" missing for $params
541 | ERROR | [ ] Type hint "array" missing for $cache_options
615 | WARNING | [x] There must be no blank line following an inline
| | comment
629 | ERROR | [x] Use null coalesce operator instead of ternary
| | operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...alytics_counter/src/Plugin/Block/GoogleAnalyticsCounterBlock.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
30 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------
FILE: ...ytics_counter/src/Plugin/Filter/GoogleAnalyticsCounterFilter.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
129 | WARNING | Line exceeds 80 characters; contains 84 characters
131 | WARNING | Line exceeds 80 characters; contains 89 characters
133 | WARNING | Line exceeds 80 characters; contains 96 characters
----------------------------------------------------------------------
FILE: ...ib/google_analytics_counter/src/GoogleAnalyticsCounterHelper.php
----------------------------------------------------------------------
FOUND 14 ERRORS AND 3 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
26 | WARNING | [x] 'Todo: get $t_arg working.' should match the
| | format '@todo Fix problem X here.'
35 | WARNING | [ ] Line exceeds 80 characters; contains 81
| | characters
58 | ERROR | [ ] Missing parameter comment
59 | ERROR | [x] Separate the @param and @return sections by a
| | blank line.
59 | ERROR | [ ] Description for the @return value is missing
69 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
72 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
76 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
98 | ERROR | [ ] Missing parameter comment
99 | ERROR | [ ] Missing parameter comment
99 | ERROR | [ ] Missing parameter type
101 | ERROR | [ ] Description for the @return value is missing
107 | ERROR | [x] Inline control structures are not allowed
110 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
113 | ERROR | [ ] Doc comment is empty
115 | ERROR | [ ] Doc comment is empty
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ytics_counter/src/GoogleAnalyticsCounterAuthManagerInterface.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace
| | declaration
44 | ERROR | [x] Expected 1 newline at end of file; 0 found
44 | ERROR | [x] The closing brace for the interface must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...lytics_counter/src/GoogleAnalyticsCounterAppManagerInterface.php
----------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace
| | declaration
27 | ERROR | [x] Parameter comment must end with a full stop
37 | ERROR | [ ] Type hint "array" missing for $parameters
37 | ERROR | [ ] Type hint "array" missing for $cache_options
45 | ERROR | [x] Parameter comment indentation must be 3 spaces,
| | found 1 spaces
54 | ERROR | [x] Expected "int" but found "integer" for parameter
| | type
72 | ERROR | [x] Expected 1 newline at end of file; 0 found
72 | ERROR | [x] The closing brace for the interface must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...nter/src/GoogleAnalyticsCounterCustomFieldGeneratorInterface.php
----------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 14 LINES
----------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace
| | declaration
18 | ERROR | [ ] Missing parameter comment
18 | ERROR | [ ] Missing parameter type
19 | ERROR | [ ] Missing parameter comment
19 | ERROR | [ ] Missing parameter type
20 | ERROR | [ ] Missing parameter comment
20 | ERROR | [ ] Missing parameter type
36 | ERROR | [ ] Description for the @return value is missing
37 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
46 | ERROR | [ ] Missing parameter comment
46 | ERROR | [ ] Missing parameter type
47 | ERROR | [ ] Missing parameter comment
47 | ERROR | [ ] Missing parameter type
59 | ERROR | [ ] Description for the @return value is missing
60 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
69 | ERROR | [ ] Description for the @return value is missing
70 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
78 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
81 | ERROR | [x] Expected 1 newline at end of file; 0 found
81 | ERROR | [x] The closing brace for the interface must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...ics_counter/tests/src/Kernel/GoogleAnalyticsCounterQueueTest.php
----------------------------------------------------------------------
FOUND 11 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
19 | ERROR | [x] Short array syntax must be used to define arrays
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 3
65 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 0
65 | ERROR | [ ] Comment indentation error, expected only 1 spaces
66 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 0
67 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 0
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 0
69 | WARNING | [x] There must be no blank line following an inline
| | comment
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 0
77 | WARNING | [x] 'todo: actual should be 0.' should match the
| | format '@todo Fix problem X here.'
78 | WARNING | [ ] Line exceeds 80 characters; contains 103
| | characters
78 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 0
78 | ERROR | [ ] Comment indentation error, expected only 1 spaces
78 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, question marks, colons, or
| | closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...counter/tests/src/Functional/GoogleAnalyticsCounterBlockTest.php
----------------------------------------------------------------------
FOUND 14 ERRORS AND 1 WARNING AFFECTING 15 LINES
----------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
8 | ERROR | [x] There must be one blank line after the last USE
| | statement; 2 found;
13 | ERROR | [ ] Doc comment short description must be on a
| | single line, further text should be a separate
| | paragraph
45 | ERROR | [ ] Missing short description in doc comment
48 | ERROR | [ ] Class property $GacInstallValidator should use
| | lowerCamel naming without underscores
70 | ERROR | [x] Doc comment short description must end with a
| | full stop
73 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
76 | ERROR | [x] Doc comment short description must end with a
| | full stop
78 | ERROR | [ ] Description for the @return value is missing
79 | ERROR | [x] Separate the @return and @throws sections by a
| | blank line.
81 | ERROR | [x] Expected 1 blank line before function; 0 found
127 | ERROR | [x] Functions must not contain multiple empty lines
| | in a row; found 2 empty lines
140 | ERROR | [x] Functions must not contain multiple empty lines
| | in a row; found 2 empty lines
142 | ERROR | [x] Expected 1 blank line after function; 0 found
143 | ERROR | [x] The closing brace for the class must have an
| | empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: .../tests/src/Functional/GoogleAnalyticsCounterAuthSettingsTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
38 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 1.84 secs; Memory: 14MB
Issue fork google_analytics_counter-3281212
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
kaszarobertComment #5
_shyComment #6
sourabhjainComment #7
sourabhjainComment #10
kaszarobertThanks for everyone's help! I committed the changes. Now no codestyle problems, existing tests green. We can finally start fixing bugs and add features.