As mentioned during other 2.0.x development tasks, the end goal is to move all of the permission calculating into a separate module. Now that Flexible permissions has a dev release, we can start with this final release blocker.

CommentFileSizeAuthor
#10 group-3280870-10.patch72.25 KBkristiaanvandeneynde
#8 group-3280870-8.patch70.61 KBkristiaanvandeneynde
#6 group-3280870-6.patch61.23 KBkristiaanvandeneynde
#4 group-3280870-4.patch55.72 KBkristiaanvandeneynde
#2 group-3280870-2.patch52.83 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-3280870-2.patch52.83 KB

Status: Needs review » Needs work

The last submitted patch, 2: group-3280870-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3280870-4.patch55.72 KB

Status: Needs review » Needs work

The last submitted patch, 4: group-3280870-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3280870-6.patch61.23 KB

Status: Needs review » Needs work

The last submitted patch, 6: group-3280870-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3280870-8.patch70.61 KB

Status: Needs review » Needs work

The last submitted patch, 8: group-3280870-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3280870-10.patch72.25 KB

Fixed a typo in flexible_permissions that was messing up caching in Group tests. Should go green as soon as the dev release is updated.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Will write change record now.

anfor’s picture

anfor commented
Status: Fixed » Needs review

Hi Kristiaan,

If I'm not mistaken, semver for contrib flexible_permissions must be modify.
Since `drupal/flexible_permissions:^1.0` does not respect composer minimum stability config to catch module beta version (currently 1.0.0-beta1).

composer --version
Composer version 2.3.5 2022-04-13 16:43:00

With minimum-stability to stable. 

composer require 'drupal/group:^2.0@alpha'

./composer.json has been updated
Running composer update drupal/group
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Info from https://repo.packagist.org: #StandWithUkraine
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/group ^2.0@alpha -> satisfiable by drupal/group[2.0.0-alpha1, 2.0.0-alpha2].
    - drupal/group[2.0.0-alpha1, ..., 2.0.0-alpha2] require drupal/flexible_permissions ^1.0 -> found drupal/flexible_permissions[dev-1.0.x, 1.0.0-beta1, 1.0.x-dev (alias of dev-1.0.x)] but it does not match your minimum-stability.
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Please open a follow-up support request. We can turn that into a bug report if multiple people have the same issue. Adding a comment to an existing issue will make it harder for others to find in case they also experience this problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.