Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

CommentFileSizeAuthor
#2 3280773-2.patch13.29 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Assigned: danflanagan8 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3280773-2.patch13.29 KB

Here's a patch. This one is really simple. Just two test needed small selector changes: PathNodeFormTest and PathMediaFormTest

I also took the liberty of changing a number of pageText(Not)Contains assertions to statusMessage(Not)Contains assertions, as I've been known to do on these Classy-to-Stark issues.

vighneshh’s picture

vighneshh commented
Status: Needs review » Reviewed & tested by the community

Looks Good
Moving To RTBC

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 9.5.x and 9.4.x, thanks!

  • catch committed 66d46fc on 10.0.x 
    Issue #3280773 by danflanagan8: Path Tests should not rely on Classy

(...
  • catch committed 41992ab on 10.1.x
    Issue #3280773 by danflanagan8: Path Tests should not rely on Classy
  • catch committed 8ec9848 on 9.5.x
    Issue #3280773 by danflanagan8: Path Tests should not rely on Classy

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.