Problem/Motivation

I have a continuous integration script with uses this module to delete old revisions. Often I have thousands of revisions, and the output of my script looks like:

>  [notice] Processing revision: 4320366
>  [notice] Processing revision: 4322126
>  [notice] Processing revision: 4323886
>  [notice] Processing revision: 4325646
>  [notice] Processing revision: 4327406
>  [notice] Processing revision: 4329166
>  [notice] Processing revision: 4330926
>  [notice] Processing revision: 4332686

Which goes on for pages and pages and pages. I have no idea if there are a few left, or thousands.

I would like to have more feedback, something like:

>  [notice] Processing revision: 4320366 of node 1234567 (566 of 8566)
>  [notice] Processing revision: 4322126 of node 1234567 (567 of 8566)
>  [notice] Processing revision: 4323886 of node 1234567 (568 of 8566)
>  [notice] Processing revision: 4325646 of node 1234568 (569 of 8566)
>  [notice] Processing revision: 4327406 of node 1234569 (570 of 8566)
>  [notice] Processing revision: 4329166 of node 1234569 (571 of 8566)
>  [notice] Processing revision: 4330926 of node 1234569 (572 of 8566)
>  [notice] Processing revision: 4332686 of node 1234569 (573 of 8566)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 Screen Shot 2022-06-12 at 1.42.43 PM.jpg66.1 KBrobert ngo
#8 Screen Shot 2022-06-12 at 1.40.30 PM.jpg117.7 KBrobert ngo
#8 3280435-feedback-message-8.patch3.91 KBrobert ngo
#7 3280435-feedback-message-2.patch3.23 KBrobert ngo
#4 Screen Shot 2022-06-09 at 5.00.40 PM.jpg191.62 KBrobert ngo
#4 3280435-feedback-message.patch2.66 KBrobert ngo

Comments

alberto56 created an issue. See original summary.

alberto56’s picture

alberto56 commented
Issue summary: View changes
alberto56’s picture

alberto56 commented
Issue summary: View changes
robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
StatusFileSize
new 3280435-feedback-message.patch2.66 KB
new Screen Shot 2022-06-09 at 5.00.40 PM.jpg191.62 KB

I've made a patch for this. Please check it out.
However, I changed the message a bit to include the title, too. 

100 / 102 - Processing revision 137 of node 3 - Euismod Venio 5

Would adding the dry-run flag and the language of the revision be more meaningful? And the repeating of "Provision" is not really needed.
What if we change it to:

// With langcode
100 / 102 - Revision 137 of node 3 - en - Euismod Venio 5

// WIth Dry-run flag and langcode:
[DRY-RUN] - 100 / 102 -  Revision 137 of node 3 - en - Euismod Venio 5

Feedback message

robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 3280435-feedback-message.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
StatusFileSize
new 3280435-feedback-message-2.patch3.23 KB

Update patch with test.

robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
StatusFileSize
new 3280435-feedback-message-8.patch3.91 KB
new Screen Shot 2022-06-12 at 1.40.30 PM.jpg117.7 KB
new Screen Shot 2022-06-12 at 1.42.43 PM.jpg66.1 KB

Update patch with new message:

Without Dry-run:
Without dry-run

With Dry-run:
With dry_run

Test failed on PHP 7.4 most likely caused by Drupal test running PHPUnit 9.x (see #3222004: phpunit.xml is using a deprecated schema) which requires a newer `phpunit.xml`.
The failed tests on PHP 7.4 seem to be irrelevant.

Please review,
Thanks

robert ngo’s picture

robert ngo
Location Montreal ⚜️
commented
Status: Needs work » Needs review
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Fixed

Thanks for the patch @Robert Ngo

  • adriancid committed 1f2b394 on 8.x-1.x authored by Robert Ngo 
    Issue #3280435 by Robert Ngo, alberto56, adriancid: Provide more...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.