Stop ignoring "Missing explicit access check on entity query." rule in core/phpstan-baseline.neon

I have fixed CS error. Please review it

Can we have a test-only patch, without the removal of the ignored pattern, to proof we do not have any lagger?

That proves that removing the ignore, there are no more errors like that reported. Thanks!

Patch in #10 is the one for commit.

1. +++ b/core/modules/migrate_drupal/src/Plugin/migrate/source/ContentEntity.php
   @@ -257,7 +257,7 @@ public function count($refresh = FALSE) {
   -    return $this->query()->count()->execute();
   +    return $this->query()->count()->accessCheck(TRUE)->execute();
   

   This is incorrect. This should be accessCheck(FALSE) - see \Drupal\migrate_drupal\Plugin\migrate\source\ContentEntity::query()

2. +++ b/core/modules/node/node.module
   @@ -586,9 +586,9 @@ function node_cron() {
        $result = \Drupal::entityQueryAggregate('node')
   -      ->accessCheck(FALSE)
          ->aggregate('created', 'MIN', NULL, $min_alias)
          ->aggregate('created', 'MAX', NULL, $max_alias)
   +      ->accessCheck(FALSE)
   
   @@ -1093,8 +1094,7 @@ function node_access_rebuild($batch_mode = FALSE) {
   -      $entity_query->accessCheck(FALSE);
   -      $nids = $entity_query->execute();
   +      $nids = $entity_query->accessCheck(FALSE)->execute();
   

   These changes don't look great to me. They look like there are still problems with the rule.

+++ b/core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php
@@ -134,9 +134,9 @@ public function checkNodeAccess(array $tree) {
+      $access_check = TRUE;
 
       $query = $this->entityTypeManager->getStorage('node')->getQuery();
-      $query->accessCheck(TRUE);
       $query->condition('nid', $nids, 'IN');
 
       // Allows admins to view all nodes, by both disabling node_access
@@ -145,14 +145,14 @@ public function checkNodeAccess(array $tree) {

@@ -145,14 +145,14 @@ public function checkNodeAccess(array $tree) {
       // entries per user.
       $access_result = AccessResult::allowed()->cachePerPermissions();
       if ($this->account->hasPermission('bypass node access')) {
-        $query->accessCheck(FALSE);
+        $access_check = FALSE;
       }
       else {
         $access_result->addCacheContexts(['user.node_grants:view']);
         $query->condition('status', NodeInterface::PUBLISHED);
       }
 
-      $nids = $query->execute();
+      $nids = $query->accessCheck($access_check)->execute();

This also looks suspiciously like the rule is not correctly implemented. This change should not be necessary.