Some parts of the UI, especially the add/create page for groupable entities are hard to alter from the outside. Let's put these type of UI strings in a handler so plugins can more easily control what they look like.

CommentFileSizeAuthor
#6 group-3280127-6.patch53.3 KBkristiaanvandeneynde
#4 group-3280127-4.patch52.92 KBkristiaanvandeneynde
#2 group-3280127-2.patch52.32 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new group-3280127-2.patch52.32 KB

This still needs a lot of change records for the new handler, altered gnode routes and removal of some code in the controller. But it's a start.

Status: Needs review » Needs work

The last submitted patch, 2: group-3280127-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3280127-4.patch52.92 KB

Order of GroupContent properties matter now, first plugin_id then label.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Things that need to happen now:

  • Update hook to remove label/description from all GCT entities + CR
  • CR for new UI text provider handler and removed plugin methods
  • CR to explain new base_plugin_id route default for GroupContentController and access checks
  • CR to explain gnode route changes (route provider and GroupNodeController gone)
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new group-3280127-6.patch53.3 KB

This removes the GCT properties.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.