• Update OpenStackImageCreateForm::save().
  • Integrate REST API processing related to OpenStack.

Issue fork cloud-3280027

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !932

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks!

Note: When this is merged, I will also create a patch for OpenStackImageEditForm.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor source codes related to OpenStackImageCreateForm » Refactor OpenStackImageCreateForm
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my minor comment.

@sekinet

Could you please review the patch? Thanks!

sekinet’s picture

sekinet commented

@ryo-yamashita @yas

The patch looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. Please change the status to Needs review next time.

@sekinet

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed. Please don't hesitate to change the status from Needs work / Needs review to RTBC.

Thanks

  • yas committed 6004bf2 on 5.x authored by Ryo Yamashita 
    Issue #3280027 by Ryo Yamashita, yas, sekinet: Refactor...

  • yas committed a6b14ff on 4.x authored by Ryo Yamashita 
    Issue #3280027 by Ryo Yamashita, yas, sekinet: Refactor...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.