Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
Olivero theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 May 2022 at 13:26 UTC
Updated:
7 Jun 2022 at 14:04 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
ckrina+1 to this simplification.
Comment #3
mherchelComment #4
longwaveThis is a nice simplification but I wonder if we should remove the other exclamation mark on the "Congratulations" line if we are adding one here, it looks a bit shouty with one on both lines.
Comment #5
mherchelMakes sense to me. I'm going to bring it to the UX meeting on Friday #3279239: Drupal Usability Meeting 2022-05-13
Comment #8
binoli lalani commentedComment #9
binoli lalani commentedComment #10
binoli lalani commentedHello,
I have changed "Welcome to " to "Welcome!" and removed exclamation mark from "Congratulations" line.
Have created a MR and attached the patch as well. Please review and let me know if require any changes.
Thanks
Comment #11
libbna commentedI have reviewed and it LGTM. Added screenshots.
Comment #12
mherchelNightwatch tests are failing (maybe we check for that text?)
Also, can we add a period after "Congratulations and welcome to the Drupal community" ?
Also, we're taking this to the UX meeting tomorrow, so there may be more changes.
Comment #13
mherchelComment #14
mherchelComment #15
mherchelI brought this to the Drupal UX meeting at #3279239: Drupal Usability Meeting 2022-05-13. There was unanimous consensus to making the the heading say "Welcome!", and swapping out the exclamation point with a period for the "Congratulations and welcome to the Drupal community" text.
Comment #16
stockfoot commentedNew contributor here, I am going to try and tackle this!
Assigning this to myself to begin making the change.
Comment #18
stockfoot commentedThe changes have been made and the merge request has been set up.
It can be viewed here - https://git.drupalcode.org/project/drupal/-/merge_requests/2272
Hopefully, I did everything correctly. Let me know if any changes are needed or if I messed up in the process of any of this, thank you!
Unassigning myself and setting status to "Needs Review"
Comment #19
mherchelLeft some feedback. We also need to fix the tests that check for this text.
Comment #20
maninders commentedHi
Created a patch for Change "Welcome to " to "Welcome!" on the initial install screen, And also added a patch for "Congratulations and welcome to the Drupal community!" to "Congratulations and welcome to the Drupal community".
Comment #23
ruturaj chaubeyAdded the requested changes to an existing MR.
MR link - https://git.drupalcode.org/project/drupal/-/merge_requests/2272
Thank you.
Comment #25
mherchelChanges from the most recent MR look perfect! The tests are green and I manually tested this out. Thank you @vighnesh-sadagopal!
Comment #26
lauriiiSince this is a significant user facing change, I think it would be good to have a sign-off from the product managers on this.
Comment #27
gábor hojtsyI think this looks fine. Less "Welcome to drush site-install" :D I agree depending on the site name used, there could be awkard combinations.
Comment #28
mherchelChange record at https://www.drupal.org/node/3282096
Comment #32
lauriiiCommitted 41761dc and pushed to 10.0.x. Also cherry-picked to 9.5.x and 9.4.x. Thanks!