A link that is styled as a button nested within rich text doesn't have proper styling. I would expect this to have regular "button" styling.

<div class="text-content">
  <a href="#" class="button button--primary">My link button</a>
</div>

Testing instructions

1. Create an article and set the input format to "Full HTML" or something that doesn't strip HTML
2. Switch to HTML input and copy and paste the following markup

<a href="" class="button button--primary">button</a>
<a href="" class="button">button</a>
<a href="" class="button button--icon-back">button</a>

3. Make sure the buttons are legible and look correct.

CommentFileSizeAuthor
#8 Screen Shot 2022-05-23 at 9.00.58 PM.png149.03 KBandy-blum
#8 Screen Shot 2022-05-23 at 8.58.28 PM.png130.32 KBandy-blum
#7 3279693-7-10.0.x.patch2.7 KBmherchel
#4 3279693-10.0.x.patch2.77 KBmherchel
#3 3279693-9.4.x.patch2.5 KBmherchel
olivero-primary-button-link.gif37.65 KBmherchel

Comments

mherchel created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.5.x-dev » 9.4.x-dev
Priority: Normal » Critical

Bumping priority on this because even after #3279640: Standard install profile uses Olivero for update.php an Olivero-only site will run into this on update.php, making it potentially blocking.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
StatusFileSize
new 3279693-9.4.x.patch2.5 KB

Patch for 9.4.x

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3279693-10.0.x.patch2.77 KB

10.0.x patch attached. Note in this patch, I use the :where() selector to remove unnecessary specificity from the selector.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes

Adding testing instructions

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3279693-7-10.0.x.patch2.7 KB

Updated patch for D10.

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2022-05-23 at 8.58.28 PM.png130.32 KB
new Screen Shot 2022-05-23 at 9.00.58 PM.png149.03 KB

9.4.x patch applies to 9.5.x as well, screenshots below.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed afd7bc2 and pushed to 10.0.x. Thanks!
Committed and pushed 9c6d3d2d17 to 9.5.x and e057e13319 to 9.4.x. Thanks!

  • alexpott committed afd7bc2 on 10.0.x 
    Issue #3279693 by mherchel, andy-blum: Olivero: Hyperlinks with "button...

  • alexpott committed 9c6d3d2 on 9.5.x 
    Issue #3279693 by mherchel, andy-blum: Olivero: Hyperlinks with "button...

  • alexpott committed e057e13 on 9.4.x 
    Issue #3279693 by mherchel, andy-blum: Olivero: Hyperlinks with "button...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.