When mentioning a user in a WYSIWYG field, on a site running on PHP 8.1, I receive the following notice:
Deprecated function: current(): Calling current() on an object is deprecated in Drupal\ckeditor_mentions\MentionsType\MentionsTypeBase->defaultConfiguration()
Install on a Drupal 9 site on PHP 8.1 and insert a mention.
I question even using `current()` to begin with. The Drupal render service works perfectly fine when rendering arrays.
Review PR.
N/A
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | ckeditor_mentions_3279121_calling_current.patch | 974 bytes | nina_jeq |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
pianomansam commentedI've created an issue fork and PR that removes the use of current() from defaultConfiguration() in MentionsTypeBase.
Comment #4
idebr commentedPatch works as expected, thanks!
Comment #5
mwebaze commented@idebr where can I find the patch you tested?
Comment #6
pianomansam commented@mwebaze the patch is linked as the "plain diff" in the issue fork section of this issue, otherwise you can access it here:
https://git.drupalcode.org/project/ckeditor_mentions/-/merge_requests/8....
Comment #7
nina_jeq commentedHi there
Here is the patch.
Comment #8
andrei.vesterliHi
I've added a test for php 8.1. Let's hope that it will succeed.
Comment #11
dinazaur commentedComment #12
andrei.vesterliHi @dinazaur
Add a credit for @nina_jeq, please.
Comment #13
dinazaur commented