Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork violinist_projects-3278260

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eiriksm created an issue. See original summary.

eiriksm opened merge request !51

liuyuanchao made their first commit to this issue’s fork.

liuyuanchao’s picture

liuyuanchao commented
Assigned: Unassigned » liuyuanchao

Run pipelines by updating fork and some phpstan errors appeared.
I will try to fix it.

liuyuanchao’s picture

liuyuanchao commented
Assigned: liuyuanchao » Unassigned
Status: Active » Needs review

Fixed.
https://git.drupalcode.org/issue/violinist_projects-3278260/-/pipelines/...

Please review, thanks.

  • eiriksm committed c26719e3 on 8.x-1.x 
    Issue #3278260 by eiriksm, liuyuanchao: Up phpstan level
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Fixed

Amazing, thank you 🙏😍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.