Problem/Motivation

Follow-up for #3268078: DBLogResource is no longer being tested.

In that issue we reinstated testing of the DBLogResource in 10.0.x-dev.
In doing so, we needed to re-add an error suppression for PHPStan here.

As pointed out correctly by @mondrake in #3268078-17: DBLogResource is no longer being tested, we really shouldn't be adding things to that file "manually", but rather fix them.

Let's do that in this issue.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3278052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Fix added core/phpstan-baseline.neon » Fix added core/phpstan-baseline.neon error for core/modules/dblog/tests/src/Functional/DbLogResourceTest.php
spokje’s picture

spokje
Primary language Dutch
commented
Title: Fix added core/phpstan-baseline.neon error for core/modules/dblog/tests/src/Functional/DbLogResourceTest.php » Fix added core/phpstan-baseline.neon error suppresion for core/modules/dblog/tests/src/Functional/DbLogResourceTest.php
Related issues: +#3268078: DBLogResource is no longer being tested

Spokje opened merge request !2204

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +PHPStan-0
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a2b684a and pushed to 10.0.x. Thanks!

  • alexpott committed a2b684a on 10.0.x 
    Issue #3278052 by Spokje, mondrake: Fix added core/phpstan-baseline.neon...

Spokje closed merge request !2204

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.