Problem/Motivation
In #3051352: [Plan] Remove unused jQuery UI components and replace with a suite of contrib packages for the continuous upgrade path we deprecated jQuery UI components that core doesn't use.
However, we still need to remove the library definitions from Drupal core.
Some core libraries are still using jquery_ui components directly, like dialog - in these cases, we can't remove the actual files, but we can still remove the library definitions.
We can do this all in one go in this issue I think - should be pure deletion.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3277744
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
catchComment #4
xjmComment #5
taran2lOkay, seems like everything can be deleted except autocomplete, which has own issue #3076171: Provide a new library to replace jQuery UI autocomplete
But, that issue feels like a lot of work and then there is a question: is there enough of time to replace autocomplete and then remove everything else for D10 beta ?
Comment #6
taran2l... I was wrong, also dialog #2158943: Add a native dialog element to deprecate the jQuery UI dialog and from that issue by @xjm:
Comment #7
catch@Taran2L - both of those core libraries don't actually depend on the jquery_ui library definitions any more, but on the files directly, so we can still remove the library definitions themselves.
Comment #8
taran2l@catch, right. But, jQuery UI code will remain in core (so will be supported) and at the same time contrib must rely on myriad of modules (that require support as well) making everything just much more complicated for the ecosystem. Maybe, maybe, we should undeprecate jQuery UI or remove it in D11 ?
Comment #9
nod_The hardship is a feature, not a bug. We're not trying to get contrib to keep using jQuery UI. It's still possible because we don't want to break everyone's code, so there is a way to keep using it for D10+. If it's important enough people might also step up to maintain those projects, because right now they're minimally maintained.
It's not supported in the sense that no one else in contrib should be using those files in their module/theme/project. Also it's not all of the jQuery UI files, some are going to be removed so we won't have the complete source of jQuery UI in core.
And maybe (that's what I hope at least) if someone in contrib has a better idea on what to use instead, they can propose it for core so that all of contrib can use that better version of the thing. It can't always be from core to contrib, if we want to have frontend folks contribute, we need more interesting frontend topics to contribute to :)
Comment #11
andypostComment #12
andypostComment #13
nod_I think there are a few files we don't need anymore. They should be removed from the source and from the
core/scripts/js/vendor-update.jsfile.Comment #14
taran2lWe are missing one more thing here,
core/tabbable.jquery.shimlibrary must be removed as well.I think this requires a separate issue, as both
core/drupal.autocompleteandcore/drupal.dialoglibraries depend on itComment #15
taran2lComment #16
catchMR looks great, can't think of anything else to do here.
Opened a follow-up for tabbable, good spot: #3278625: Deprecate/remove jquery.tabbable.shim.
Comment #17
nod_looks good to me to! thanks
Comment #18
alexpottCommitted f0f493c and pushed to 10.0.x. Thanks!
I thought about a CR here but I think we just need to attach the existing CRs - going to do that now.
Comment #21
quietone commentedComment #22
joseph.olstaddust hasn't settled in contrib related to this change Might be holding onto D9 for a while longer than anticipated.