Problem/Motivation

#3274767: Update to CKEditor 5 v34.0.0 got us on CKEditor 5 v34.0.0.

But the ckeditor5-list package's DLL build did not include the DocumentList plugin, only the List plugin. We need DocumentList. For example for the #3274651: Impossible to enable <ol type> or <ul type> with GHS: switch to List's successor, DocumentList stable blocker.

https://github.com/ckeditor/ckeditor5/releases/tag/v34.0.1 does not exist, only https://github.com/ckeditor/ckeditor5/releases/tag/v34.0.0.

Only https://www.npmjs.com/package/@ckeditor/ckeditor5-list got a 34.0.1 release, just for us, so we can start using DocumentList.

This hard-blocks the stable blocker #3274651, see #3274651-6: Impossible to enable <ol type> or <ul type> with GHS: switch to List's successor, DocumentList.

Proposed resolution

  1. core/package.json
  2. cd core
  3. yarn install
  4. yarn run vendor-update
  5. yarn run build:ckeditor5
  6. yarn run build:ckeditor5-types

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

N/A

CommentFileSizeAuthor
#6 3277405-6.patch153.74 KBwim leers
#6 interdiff.txt697 byteswim leers
#4 3277405-4.patch153.74 KBwim leers
#4 interdiff.txt707 byteswim leers
#2 3277405-2.patch153.75 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3277405-2.patch153.75 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Needs work 
+++ b/core/core.libraries.yml
@@ -175,10 +175,10 @@ ckeditor5.link:
+    url: https://github.com/ckeditor/ckeditor5/blob/v34.0.1/LICENSE.md

Unfortunately this is a 404, will need to add a @todo there to make sure we'll get it updated when v35 or v34.1 gets out since having a different version here and in version will prevent the auto update of the license link

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt707 bytes
new 3277405-4.patch153.74 KB

Discussed with @nod_ in chat. He means: revert back to the 34.0.0 link (so that it's not a 404) and add a @todo to ensure it's updated in 35.0.0.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
+++ b/core/core.libraries.yml
@@ -160,7 +160,8 @@ ckeditor5.list:
+    # @todo A 34.0.1 link does nit exist; https://www.drupal.org/project/drupal/issues/3277438 will make this in sync again.

s/nit/not/ 🙈

Canceling test…

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt697 bytes
new 3277405-6.patch153.74 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks!

  • lauriii committed e041ed7 on 10.0.x 
    Issue #3277405 by Wim Leers, nod_: Update @ckeditor/ckeditor5-list to...

  • lauriii committed 0bf8496 on 9.4.x 
    Issue #3277405 by Wim Leers, nod_: Update @ckeditor/ckeditor5-list to...

  • lauriii committed 50f1392 on 9.3.x 
    Issue #3277405 by Wim Leers, nod_: Update @ckeditor/ckeditor5-list to...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed e041ed7 and pushed to 10.0.x. Also cherry-picked to 9.4.x and 9.3.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +10.0.0 release notes, +9.4.0 release notes, +9.3.13 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.