Problem/Motivation

On editor init, Media view modes result in a ckeditor5-dll.js?v=34.0.0:5 toolbarview-item-unavailable {name: 'drupalMedia:viewMode'} error if alignment is not also enabled for media. Failing test will be added in a comment

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3276974-10.patch3.15 KBwim leers
#2 viewModesRequireAlignment-TEST-ONLY.patch3.11 KBbnjmnm

Issue fork drupal-3276974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
StatusFileSize
new viewModesRequireAlignment-TEST-ONLY.patch3.11 KB

Status: Needs review » Needs work

The last submitted patch, 2: viewModesRequireAlignment-TEST-ONLY.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Media View Modes don't work if alignment not enabled » [drupalMedia] Media View Modes don't work if alignment not enabled
Parent issue: » #3238333: Roadmap to CKEditor 5 stable in Drupal 9

hooroomoo made their first commit to this issue’s fork.

hooroomoo opened merge request !2168

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Needs work » Needs review

Thankfully a simple fix 😅🤠

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Needs work

test still failing

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3276974-10.patch3.15 KB

🚢

MR commit a2dd10bb in patch form should apply to all 3 branches.

  • bnjmnm committed 72c2508 on 10.0.x 
    Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes...

  • bnjmnm committed 5996e3a on 9.4.x 
    Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes...

  • bnjmnm committed f4bd24f on 9.3.x 
    Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View Modes...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Version: 10.0.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 10.0.x and 9.4.x as well as a backport to 9.3.x as CKEditor is experimental and this is a bug that should be fixed there as well.

catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Needs work

I think this broke HEAD, looks like potentially a frequent random fail, haven't looked beyond finding this in the list of recent commits in roughly the same area: https://www.drupal.org/pift-ci-job/2370367

catch’s picture

catch
he/him
Primary language English
commented

Since there are a lot of issues trying to land this week, I have reverted this only from 10.x in the hope of getting DrupalCI back to green. If this issue is indeed the source of the failures, then we can recommit to 10.x with the fix,and backport the testing fix to 9.4.x and 9.3.x (or if it turns out to be really tricky, we could rollback from 9.4/9.3 for a bit too, but left it for now).

  • catch committed 45ee80d on 10.0.x 
    Revert "Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia] Media View...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

I think those tests are testing CKEditor 4 which makes it seem unlikely that this issue would have caused them 🤔

  • catch committed a9ac24a on 10.0.x 
    Revert "Revert "Issue #3276974 by hooroomoo, Wim Leers: [drupalMedia]...
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Fixed

hmm good point, bit too quick there. Reverted the revert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.