Problem/Motivation

\Drupal\ckeditor5\SmartDefaultSettings::addTagsToSourceEditing returns $messages, but messages are now handled differently by the methods that call this.

This is either an opportunity to remove a few LOC or to add a comment explaining why there are still messages being returned despite none of the calls using a return value.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

bnjmnm created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3245967: Messages upon switching to CKEditor 5 are overwhelming

This might get solved as part of #3245967: Messages upon switching to CKEditor 5 are overwhelming? 🤞

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: The return value of addTagsToSourceEditing is never used » [PP-1] The return value of addTagsToSourceEditing is never used
Status: Active » Postponed
Related issues: +#3317769: Add support for linking to entities in CKEditor 5

#2: it didn't get solved as part of that.

#3317769: Add support for linking to entities in CKEditor 5 is touching this file again, and is removing a lot, but won't be removing this particular code. Let's get this cleaned up after that issue is done 😊

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.