Quoting @hooromoo from #3269657-11: [drupalMedia] The CKEditor 4 → 5 upgrade path for the media_embed filter should not forcefully allow the `data-view-mode` attribute on `<drupal-media>`
2. In Drupal\Tests\ckeditor5\FunctionalJavascript\AdminUiTest::testPluginSettingsFormSection I am not sure why the media plugin is enabled when the media_embed filter is disabled.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !2149
Comments
Comment #3
wim leersReason this is being found now: #3269657: [drupalMedia] The CKEditor 4 → 5 upgrade path for the media_embed filter should not forcefully allow the `data-view-mode` attribute on `<drupal-media>` is making
media_mediathe very first filter-dependent configurable CKE5 plugin.Good find, @hooroomoo!
Working on test.
Comment #5
wim leersComment #6
wim leersComment #7
hooroomooLooks good to me, waiting for the tests pass now
Comment #10
catchCommitted/pushed to 10.0.x, cherry-picked to 9.4.x and 9.3.x, thanks!
Comment #12
wim leersYay, that means #3269657: [drupalMedia] The CKEditor 4 → 5 upgrade path for the media_embed filter should not forcefully allow the `data-view-mode` attribute on `<drupal-media>` is unblocked! Thanks :)