Related issue: #3156244: Title variable isn't set by Syndicate block - so the link text is an unfinished sentence

Currently the RSS Feed icon block shows to the left of the content within Drupal's default theme, Olivero.

The text next to the icon is hard coded to display the site-name, which is counter-intuitive, and doesn't make sense to people who may not be able to recognize the RSS icon.

Furthermore the configure block UI gives the user the option to change the "Title"... but changing this value has absolutely no effect.

Release notes snippet

The RSS feed block title now reflects the block title as configured, instead of being hard-coded to the site name.

Issue fork drupal-3276108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

zenimagine created an issue. See original summary.

libbna’s picture

hi @zenimagine, can you provide a screenshot for more clarity on the issue? Thanks.

zenimagine’s picture

Status: Active » Closed (works as designed)
mherchel’s picture

Title: The title "RSS Feed" is replaced by the name of the site » Allow the RSS Feed block's title to be customized by user
Component: Olivero theme » system.module
Category: Support request » Task
Issue summary: View changes
Status: Closed (works as designed) » Active
StatusFileSize
new190.69 KB

This is a valid issue IMHO. Re-openinig and updating summary.

jasonfelix made their first commit to this issue’s fork.

jasonfelix’s picture

Version: 9.4.x-dev » 9.5.x-dev
Assigned: Unassigned » jasonfelix
Status: Active » Needs review
StatusFileSize
new625 bytes

Fixed the core/modules/node/src/Plugin/Block/SyndicateBlock.php to get the title of the Block instead of the site name.

Status: Needs review » Needs work

The last submitted patch, 6: 9.5.x-3276108-4.patch, failed testing. View results

jasonfelix’s picture

Status: Needs work » Needs review
StatusFileSize
new625 bytes
new625 bytes
new625 bytes
new53.59 KB
new48.74 KB
new63.22 KB

Patched for 9.4.x, 9.5.x, and 10.0.x

Status: Needs review » Needs work

The last submitted patch, 8: 10.0.x-3276108-7.patch, failed testing. View results

jasonfelix’s picture

Version: 9.5.x-dev » 9.4.x-dev
Status: Needs work » Needs review
StatusFileSize
new0 bytes

I modified the Test so it matches the output of the block.

jasonfelix’s picture

StatusFileSize
new1.39 KB

The previous patch was blank. This one is not. My apologies.

The last submitted patch, 8: 9.4.x-3276108-7.patch, failed testing. View results

The last submitted patch, 8: 9.5.x-3276108-7.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 11: 9.4.x-3276108-10.patch, failed testing. View results

mherchel’s picture

Issue summary: View changes
mherchel’s picture

Issue tags: +Needs followup

I brought this to the Drupal UX meeting at #3279239: Drupal Usability Meeting 2022-05-13. There was unanimous consensus that this text should be configurable (as long as it does affect the actual RSS feed, which it will not).

We also need to open a followup to address the fact that the icon is currently hidden from screen readers (via aria-hidden="true". Currently, if a screen reader user looks to the link it will just announce the site-name text, and the user will not know that it links to a RSS feed.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

jasonfelix’s picture

Status: Needs work » Needs review
StatusFileSize
new1.74 KB

Fixed the NodeSyndicateBlockTest to change the label of the block and search for the block label text on the home page.

lauriii’s picture

This makes sense to me, but I guess this could be bit of a BC break, and I'm not sure if a change record would be enough for handling this. Also, deprecating \Drupal\node\Plugin\Block\SyndicateBlock as a whole seems like a bit much, but I'm not sure I can think of anything else. I guess an alternative could be to update the block title to site name to keep the behavior on FE intact, but that could be confusing too.

mherchel’s picture

Status: Needs review » Reviewed & tested by the community

This works great.

catch’s picture

fwiw I think changing where the title comes from is fine as a straight bugfix without worrying about BC. If the site owner has put something weird in as the block title, they can go into configuration and change it. I don't think we can account for that situation while also accounting for people that put in a custom title they want to use but is currently not used.

However we should only commit this to a minor so it's not a surprise in a patch release for anyone.

mherchel’s picture

  • catch committed 626d170 on 10.0.x
    Issue #3276108 by jasonfelix, mherchel, zenimagine, lauriii: Allow the...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.5.x, thanks!

  • catch committed 981f57c on 9.5.x
    Issue #3276108 by jasonfelix, mherchel, zenimagine, lauriii: Allow the...
catch’s picture

Issue summary: View changes
catch’s picture

Issue summary: View changes
Issue tags: +9.5.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

Issue tags: -Needs followup

I created the follow up asked for in #16, #3315046: The feed icon is hidden from screen readers, so I am removing the tag.