Problem/Motivation
Several implementations of getInstance() don't return the value described in the following documentation comment.
* @return object|false
* A fully configured plugin instance. The interface of the plugin instance
* will depend on the plugin type. If no instance can be retrieved, FALSE
* will be returned.
FormatterPluginManager and WidgetPluginManager return NULL instead of FALSE.
Proposed resolution
Change the code to return FALSE as documented.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3275585-6.patch | 3.03 KB | dspachos |
Comments
Comment #2
avpadernoComment #3
avpadernoComment #4
dspachos commentedhere is a quick patch
Comment #5
dspachos commentedComment #6
dspachos commentedComment #7
avpadernoComment #8
joachim commentedLGTM!
Comment #11
catchCommitted/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!