Add a REST API and modify the SPA source code as well.

Issue fork cloud-3275389

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !867

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ryo-yamashita

Thank you for the patch. It looks good to me.

@xiaohua-guan

What do you think?

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Needs work

@yas @ryo-yamashita

I posted my comments. Please check them.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas @xiaohua-guan

I pushed fix patches. Please review it again.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita @yas

Thanks for your code. It looks good to me now. So I changed the status to RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ryo-yamashita

Thank you for the update.

@xiaohua-guan

Thank you for your review.

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed f217093 on 5.x authored by Ryo Yamashita 
    Issue #3275389 by Ryo Yamashita, yas, Xiaohua Guan: Add the function to...

  • yas committed 916db1a on 4.x authored by Ryo Yamashita 
    Issue #3275389 by Ryo Yamashita, yas, Xiaohua Guan: Add the function to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.