Yesterday's security update causes regressions.
I bumps the php version requirement to 5.4+ (without notifying about that). OK, that one's for sure less dramatic. The new requirement for the php-intl extension has its own issue.

It breaks aliases for user account urls when pathauto is in use.

Steps to reproduce

  • Make sure pathauto is installed, an alias pattern for user is set and aliases exist
  • Make sure "Rename user path" setting is enabled
  • Update rename_admin_paths
  • Try to access any of the aliases to user pages

Proposed resolution

The odd thing is that it's attempted to sanitize $original_path, but in fact, the code acts on $path.

https://git.drupalcode.org/project/rename_admin_paths/-/commit/dc30870b2...

Is that just an oversight, or something fancy I simply don't understand?

CommentFileSizeAuthor
#11 rename_admin_path_issue_3275205.patch787 bytesabferris
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

indigoxela created an issue. See original summary.

indigoxela’s picture

Issue summary: View changes
indigoxela’s picture

Issue summary: View changes
laborouge’s picture

+1

katebron’s picture

I thought this was the error i had, but i actually can't get this far. Because the update crashes my sites, this is more applicable: https://www.drupal.org/project/rename_admin_paths/issues/3275140. Would delete this comment if i could!

othermachines’s picture

The extension requirement should be in the release notes.

(Edited out info explaining fix since this is a security issue.)

indigoxela’s picture

The problem described here (not the intl requirement, but the inaccessible user page aliases) could easily get fixed by transliterating the right variable:

$normalized_path = $transliterator->transliterate($original_path);

saxmeister’s picture

Same exact issue here.

  • Had to install php_intl extension
  • Installed
  • Set up alias (it was already set up in the Admin UI)
  • All /user/ paths were broken

- Extension requirement needs to be in notes
- PHP 5.4+ requirement change needs to be in notes

gabrlknght’s picture

@indigoxela many thanks for that quick fix! Two doozies from a single module update is enough 😅

jon pollard’s picture

@indigoxela many thanks, just want to flag this up again - line 108(ish) in rename_admin_paths.module

replace this

$normalized_path = $transliterator->transliterate($path);

with this

$normalized_path = $transliterator->transliterate($original_path);

abferris’s picture

StatusFileSize
new787 bytes

This is my first time trying to give back a patch file to the community.

I tested the change suggested by IndigoLexa in comment #7. This has also been pointed out by Jon Pollard

Please let me know what changes I should make for the file or any posting goofs I made.

leducdubleuet’s picture

Priority: Normal » Major
Status: Active » Reviewed & tested by the community

The patch in #11 does the job to fix this major issue.

Thank you very much!

kliker’s picture

Issue tags: +404, +users, +alias, +pathauto

Thank you, patch fixes the issue with inaccessible /users/* pages.

webengr’s picture

I can confirm that on a drupal7 website with php 7.3, move to a server with php 8.0 with core at latest and many of the modules pushing dev to support php 8.0 that the problem persisted.

I edited line 108ish as recommended by Pollard and indigoxela, and it is FIXED !!!

TRULY this needs to be fixed. It has been broken a long time, I was ignoring it being broken but it was messing up users also.

Raphael Apard made their first commit to this issue’s fork.

  • Raphael Apard committed 6a29111b on 7.x-2.x
    Issue #3275205 by Raphael Apard, abferris, indigoxela, saxmeister,...
raphael apard’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for you work !

raphael apard’s picture

Status: Fixed » Closed (fixed)