Problem/Motivation

The method to receive a list of events was called actions before. This got renamed to definitions in beta-8 of ECA and we need to adjust that for the integration here as well.

Issue fork entity_share-3274756

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !50

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review
rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Status: Needs review » Reviewed & tested by the community

Before I was made aware of this issue and patch I've updated to the latest version of ECA and Entity Share which caused a fatal error when installing entity_share_eca. Applying the patch and clearing the cache fixed the fatal error.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

Do you think it will be better to create a dedicated entity_share_eca project on drupal.org?

Because, there are regularly issues to update the module and Entity Share releases may not be synchronized with ECA releases.

  • Grimreaper committed deab032 on 8.x-3.x authored by jurgenhaas 
    Issue #3274756 by jurgenhaas, rkoller, Grimreaper: Changed method name...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: jurgenhaas » Unassigned
Status: Reviewed & tested by the community » Fixed
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

Do you think it will be better to create a dedicated entity_share_eca project on drupal.org?

Because, there are regularly issues to update the module and Entity Share releases may not be synchronized with ECA releases.

We are close to 1.0-RC1 and won't expect any such changes, at least not with such a frequency anymore. Still, I've had the same thought and it would make both of us more flexible, if we extracted the integration into a separate module. We've done the same for Tamper and for State Machine integrations. More will follow and I think, we should do the same thing here too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.