CommentFileSizeAuthor
#7 after-patch-apply.png64.3 KBroshni27
#7 after-module-installtion.png62.39 KBroshni27
#7 before -module-installation.png64 KBroshni27
#5 after-patch-ss.png47.68 KBsnehal-chibde
#5 before-patch-ss.png41.5 KBsnehal-chibde
#5 status_message_time_ago_fix_3273781.patch1.22 KBsnehal-chibde
#2 update-modules-page_time-ago.jpg34.35 KBTamB

Comments

OMD created an issue. See original summary.

TamB’s picture

TamB commented
StatusFileSize
new update-modules-page_time-ago.jpg34.35 KB

I can confirm this happens, in particular on the Update modules page (/admin/modules/update). See attached pic.

TamB’s picture

TamB commented
Title: Status Messages module removes "time ago" date stamp in forums » Status Messages module removes "time ago" date stamps
snehal-chibde’s picture

snehal-chibde commented

This issue is getting replicated. I am working on the solution.

snehal-chibde’s picture

snehal-chibde commented
Issue summary: View changes
StatusFileSize
new status_message_time_ago_fix_3273781.patch1.22 KB
new before-patch-ss.png41.5 KB
new after-patch-ss.png47.68 KB

This is resolved.
Refer before and after screenshots for reference.

snehal-chibde’s picture

snehal-chibde commented
Status: Active » Needs review
roshni27’s picture

roshni27 commented
StatusFileSize
new before -module-installation.png64 KB
new after-module-installtion.png62.39 KB
new after-patch-apply.png64.3 KB

I have review this #5 patch and it is cleanly applied . This issue is resolved please checkout the screenshots.
+1 RTBC

keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community
elgandoz’s picture

elgandoz commented
Status: Reviewed & tested by the community » Needs work

When using this patch I'm getting this error:
Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\status_messages\Form\StatusMessages->submitForm() (line 60 of /var/www/html/web/modules/contrib/status_messages/src/Form/StatusMessages.php)

The settings form won't save, causing the status messages to disappear very quickly.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Fixed

In the form config, the field was still named as time, now renamed to status_message_time and pushed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.