Require Token module

Thanks for fast feedback. I am not sure how to fix it, so I hope some one else can step in, and do the required adjustments to the code.

Is it only in the case of Entity References from URL that the current version doesn't work, or also in other cases?

Sorry if I haven't explained the issue clearly enough: My main problem is that a reference field is not getting prepopulated if the Token module is not enabled. As soon as I enable the Token module, the field gets prepopulated. The missing "Browse available tokens." is a secondary issue.

I don't see any instructions at any point.

This is what I did:

1. Added a new content type "Chapter"
2. Added a new field, Reference > Content called "Main article"
3. Selected "Article" under Reference type > Content type
4. Added target_id: '[current-page:query:test]' under "Entity Prepopulate"
5. Went to /node/add/chapter?test=3 (an existing node ID) and saw no prepopulation
6. Enabled Token module, and the field was prepopulated

EDIT: Reading your answer again, I think you did get it the first time :) So yes, your proposal of finding code elsewhere to display a Token module requirement under Entity Reference fields (if Token module is missing) makes sense.

Thanks for clarifying the situation, and that my observations were correct after all :)

But why can't Token be added as a requirement? I would consider entity reference support essential. As a case in point, it's used in the image on the project page. Also, in my mind, having no token browser available is a handicap, essentially making the user fly blind.

The Token module is the second most installed module, installed on 278,000 out of 430,000 +D8 installations, so it's not exactly obscure or un-maintained.

https://www.drupal.org/project/usage/drupal
https://www.drupal.org/project/usage/token

And by the way, I forgot to thank you for making this awesome module! Much simpler than the Prepopulate module.

Heh, I believe you. It looks like #229568: [polilcy, no patch] Pathauto in core requires Token (or parts of it), so I am keeping my fingers crossed it will happen some day.

Yet, I just tried the epp module with Text (plain) field, a User field, a Number (integer) field and they all required Token module to work, like an entity reference field does.

So essentially, without the Token module, for which type of field does the module work?

Great saying! Though I am glad I practiced my Drupal skills on mostly my own projects in the beginning: "That module looks cool, let me add it". I have since become a follower of Ted Bowman's philosophy "There's a module for that! Don't use it!" :)

So, if Token module will not be required, should we check if the Token module is enabled, and if not, change the description? Perhaps something like this around line 90 in epp.module?

if "Token module enabled" {
  $description = t('For Entity Prepopulation to work and Token browser access, please install the Token module.');
  } else {
  $description = t('The values will only be applied if all tokens are replaced. If the value is not valid, no replacement will happen. You can use Yaml syntax to target field properties. You can use tokens.');
}

$form['third_party_settings']['epp']['value'] = [
  '#description' => $description,

I'll try to roll an MR, so thanks for the suggestion to use the new GitLab code search feature, it's a killer feature! And great idea to link to the documentation page. Would this be more precise?

For more tokens and Token browser access, please install the Token module. See the documentation for more.

I have created #3274425: Add Token module information, it was actually surprisingly easy.

Let's close this issue, and hope that Pathauto and Token gets into core eventually, at which point we can revisit this issue :)