Problem/Motivation

I created a bootstrap5 subtheme and want to modify the horizontal padding for tables.

Steps to reproduce

  1. In a bootstrap5 subtheme, modify the table-cell-padding-x value in _variables_bootstrap.scss
  2. Build the stylesheet
  3. Inspect the resulting style.css file or view a page that includes a table and inspect it.
  4. The horizontal padding for tables has not changed to the value set

Proposed resolution

In bootstrap5/scss/_variables_bootstrap.scss, add !default when setting table-cell-padding-x so it can be overridden by the subtheme.

CommentFileSizeAuthor
#8 patch-applied-cleanly.png69.55 KBanoopsingh92
#4 table-cell-padding-3273549-4.patch372 bytesshyam_bhatt

Issue fork bootstrap5-3273549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roderickgadellaabsl created an issue. See original summary.

roderickgadellaabsl’s picture

roderickgadellaabsl commented
Issue summary: View changes
shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Assigned: Unassigned » shyam_bhatt
shyam_bhatt’s picture

shyam_bhatt
he/him
commented
StatusFileSize
new table-cell-padding-3273549-4.patch372 bytes

Updated the variable with !default. Please check the patch.

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Assigned: shyam_bhatt » Unassigned
Status: Active » Needs review

anoopsingh92 made their first commit to this issue’s fork.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: Unassigned » anoopsingh92
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new patch-applied-cleanly.png69.55 KB

Hi @Shyam_Bhatt, I reviewed your patch #4. It is applied successfully for me and It looks good to me. Thanks for the patch.
Patch #4
Moving it to RTBC. Thanks.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 1.1.3 » 1.1.x-dev
Status: Reviewed & tested by the community » Fixed

Thank you. Compiled and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.