Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Before the upgrade
Merging table cells is not possible in the editor. The button is present and not disabled, but the cells are not merged after clicking it. allowed_html contains <td> without <colspan> attribute.
After the upgrade
Merging table cells is possible in the editor. The button is present and the cells are merged in the editor, but the cells are not merged in the processed output. allowed_html contains <td> without <colspan> attribute.
Steps to reproduce
I attached the before and after configs. I also attached the custom filter_responsive_table filter plugin to be sure, but I don't think that's the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3273332-2.patch | 580 bytes | Wim Leers |
| advanced-editor-after.yml | 1.1 KB | DieterHolvoet | |
| advanced-editor-before.yml | 1.1 KB | DieterHolvoet | |
| advanced-format-after.yml | 1.76 KB | DieterHolvoet | |
| advanced-format-before.yml | 1.76 KB | DieterHolvoet | |
Comments
Comment #2
Wim LeersGREAT FIND! 🤩
Could you try again with this patch applied? 🤓 (Note that you will have to apply the patch, clear caches, go to your text format and hit "Save" again.)
This is something we missed a long time ago, in #3209613: Add "Table" plugin, long before the CKEditor 5 was anywhere near stable … 😅
Comment #3
DieterHolvoet CreditAttribution: DieterHolvoet at Minsky commentedWorks! Thanks :)
Comment #4
Wim LeersThanks! 🥳
Comment #5
Wim LeersComment #6
alexpottCommitted 28bdfa2 and pushed to 10.0.x. Thanks!
Committed 4d9db67 and pushed to 9.4.x. Thanks!
Committed 81cb15e and pushed to 9.3.x. Thanks! >
Discussed whether a test is necessary with @Wim Leers and @lauriii - we decided that is was not because @Wim Leers felt it might not be possible and regression is unlikely.