WSM allows to fully set parameters for third party service API call and retrieve data (headers, parameters, ...)
Call results can be directly rendered in a template or imported as node.

WSM comes with a field type that permit call of the API on node rendering.

Project link

https://www.drupal.org/project/wsm

Git instructions

git clone --branch '1.0.x' https://git.drupalcode.org/project/wsm.git

Comments

julien_g created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs work

Thank you for applying! For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.

The purpose of these applications is reviewing a project to understand what the user who applies knows about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API. When most of the code has been written by another user, this review cannot be easily done.

julien_g’s picture

julien_g commented
Status: Needs work » Active

Hi @apaderno,

thanks for you reply.

In fact, all commits are mine, but the first once, I had an issue with Drupla's git config and my other git repo configs (issue in the email config key). That's why the commits owns my name but are not linked to my Drupql.org's account.

Of course I understand the point but be sure that at least 90% of the module code is mine.

Let me know if you want me to do some commits to fit this requirement.

Regards.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  • This is a quick review that doesn't mean to be complete
  • Each point describes what needs to be changed to have secure code that correctly uses the Drupal API and that follows the Drupal coding standards
  • The review points are listed in order of importance as much as possible: first the points about security issues, then the points about code that doesn't correctly use the Drupal API; the points about wrong branch names, branch names that should be avoided because they are too similar, or code that doesn't follow the Drupal coding standards are listed for last
/**
 * @file
 * Contains \Drupal\linkit\Form\Profile\AddForm.
 */

Files containing a single class don't need the @file directive.

/**
 * Controller for profile addition forms.
 *
 * @see \Drupal\linkit\Profile\FormBase
 */

That comment seems referring the wrong class.

Why isn't the EndpointController class used to implement a service?

julien_g’s picture

julien_g commented
Status: Needs work » Needs review

Hi @apaderno,

thanks for your feedback.

I have applied changes regarding your feedbacks :

  • Removed all useless @file comment
  • Reviewed and fixed all class / parameters comments
  • Changed the endpoint controller to a WSM Service
  • Tested the module again
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.