Metatag v2 is going to break APIs and have some major architecture changes: #3272774

Schema.org Metatag will need to adjust accordingly.

CommentFileSizeAuthor
#17 schema_metatag-n3272777-17.interdiff.txt7.34 KBdamienmckenna
#17 schema_metatag-n3272777-17.patch18.84 KBdamienmckenna
#16 schema_metatag-n3272777-16.patch23.29 KBdamienmckenna
#16 schema_metatag-n3272777-16.interdiff.txt3.2 KBdamienmckenna
#14 schema_metatag-n3272777-14.patch20.1 KBdamienmckenna
#14 schema_metatag-n3272777-14.interdiff.txt1.11 KBdamienmckenna
#11 schema_metatag-n3272777-11.interdiff.txt5.94 KBdamienmckenna
#11 schema_metatag-n3272777-11.patch20.01 KBdamienmckenna
#10 schema_metatag-n3272777-10.patch20.02 KBdamienmckenna
#10 schema_metatag-n3272777-10.interdiff.txt5.94 KBdamienmckenna
#9 schema_metatag-n3272777-9.interdiff.txt1.1 KBdamienmckenna
#9 schema_metatag-n3272777-9.patch14.07 KBdamienmckenna
#4 schema_metatag-n3272777-4.patch13.29 KBdamienmckenna
#2 schema_metatag-n3272777-2.patch323 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new schema_metatag-n3272777-2.patch323 bytes

A starting point - change the composer requirement to Metatag v2.

Status: Needs review » Needs work

The last submitted patch, 2: schema_metatag-n3272777-2.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new schema_metatag-n3272777-4.patch13.29 KB

This includes a change to all test classes to better control the test modules that are loaded, and schema_metatag_test now depends upon 'node'.

Status: Needs review » Needs work

The last submitted patch, 4: schema_metatag-n3272777-4.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Tests pass with some changes committed to Metatag (#3333595: Tidy codebase after custom separator logic was added)! Woot!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Tests still pass, even after additional API changes. Double-woot!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Metatag 2 will require PHP 8, so we'll need to adjust the documentation and automated testing for the new branch, and maybe also the composer and info files just for completeness sake.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new schema_metatag-n3272777-9.patch14.07 KB
new schema_metatag-n3272777-9.interdiff.txt1.1 KB

Bump the PHP requirements.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new schema_metatag-n3272777-10.interdiff.txt5.94 KB
new schema_metatag-n3272777-10.patch20.02 KB

WIP to hopefully fix the API problems.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new schema_metatag-n3272777-11.patch20.01 KB
new schema_metatag-n3272777-11.interdiff.txt5.94 KB

Doh. Sorry, this should work.

Status: Needs review » Needs work

The last submitted patch, 11: schema_metatag-n3272777-11.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new schema_metatag-n3272777-14.interdiff.txt1.11 KB
new schema_metatag-n3272777-14.patch20.1 KB

This seems to fix it locally.

Status: Needs review » Needs work

The last submitted patch, 14: schema_metatag-n3272777-14.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new schema_metatag-n3272777-16.interdiff.txt3.2 KB
new schema_metatag-n3272777-16.patch23.29 KB

Hopefully this fixes the last one.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new schema_metatag-n3272777-17.patch18.84 KB
new schema_metatag-n3272777-17.interdiff.txt7.34 KB

Reverting some of the method return type declarations, which wasn't needed right now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3335953: Plan for Schema Metatag 3.0.0

I think this is ready to go.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Plan for Metatag 2 compatibility » Resolve compatibility with API changes in Metatag 2.
Category: Plan » Task
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Resolve compatibility with API changes in Metatag 2. » Resolve compatibility with API changes in Metatag 2
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed to the new 3.0.x branch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-2.x-dev » 3.0.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.