Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

CommentFileSizeAuthor
#3 3272746-3.patch585 bytesshashwat purav

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Issue tags: +Novice

The layout_discovery module only has one mention of classy: as the base theme of the test theme test_layout_theme. From what I can tell, classy is not providing anything important. The templates of the layouts being tested are provided by the layout_test module (in system). Nothing to do with classy.

The only change required is to change that classy<code> to stark in test_layout_theme.info.

Setting as Novice.

shashwat purav’s picture

shashwat purav commented
Status: Active » Needs review
StatusFileSize
new 3272746-3.patch585 bytes

Created patch to change Classy to Stark.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Status: Needs review » Reviewed & tested by the community

Thank you for the patch, @Shashwat Purav.

That said, I was really hoping this issue would be handled by a Novice contributor. Looking at your profile (and the fact you posted another patch 5 minutes after this), you are clearly not a Novice.

It is important for the community to save Novice issues for Novices so that they can build the skills and confidence needed to contribute. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b2f2bc1e1b to 10.0.x and 07712edcd5 to 9.4.x and f0d9ba0071 to 9.3.x. Thanks!

Backported to 9.3.x to keep tests aligned.

  • alexpott committed b2f2bc1 on 10.0.x 
    Issue #3272746 by Shashwat Purav, danflanagan8: Layout Discovery tests...

  • alexpott committed 07712ed on 9.4.x 
    Issue #3272746 by Shashwat Purav, danflanagan8: Layout Discovery tests...

  • alexpott committed f0d9ba0 on 9.3.x 
    Issue #3272746 by Shashwat Purav, danflanagan8: Layout Discovery tests...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.