Add a REST API and modify the SPA source code as well.

Issue fork cloud-3272661

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !819

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add the function to create Vmware VM in the SPA » Add the function to create VMware VM in the SPA
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I have modified the code so that forms can be added simply by editing the template file.

  • src/constant/form_template/entity_form_template.ts
  • src/constant/form_template/vmware/vm.ts

Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the patch. It looks good to me. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 289ccaf on 5.x authored by Ryo Yamashita 
    Issue #3272661 by Ryo Yamashita, yas: Add the function to create VMware...

  • yas committed 0221bbb on 4.x authored by Ryo Yamashita 
    Issue #3272661 by Ryo Yamashita, yas: Add the function to create VMware...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Ryo Yamashita opened merge request !822

ryo yamashita’s picture

ryo yamashita commented
Status: Fixed » Needs review

@yas

I fixed a code that was in violation of coding conventions. Please review it. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the hotfix. I'll merge the patch to 5.x, and close this issue as Fixed.

  • yas committed af8793d on 5.x authored by Ryo Yamashita 
    Issue #3272661 by Ryo Yamashita, yas: Hotfix - Add the function to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed 665df6d on 4.x authored by Ryo Yamashita 
    Issue #3272661 by Ryo Yamashita, yas: Hotfix - Add the function to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.