Problem/Motivation

D8 is EOL and the 3.x branch appears to have always been intended to target D9.

If we had been close to a stable during D8 life it may have made sense to have 3.0 target D8+D9 however we are well past EOL right now and only recently tagged an Alpha to allow the dev branch to continue forward without impacting deployed sites.

Steps to reproduce

Review readme and info.yml.

Proposed resolution

Set D9.0 as minimum supported version for 3.x branch.

Remaining tasks

User interface changes

None

API changes

No longer indicate comparability with D8.

Data model changes

None

Issue fork rabbitmq-3272169

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cmlara created an issue. See original summary.

larisse made their first commit to this issue’s fork.

larisse opened merge request !18

larisse’s picture

larisse commented
Status: Active » Needs review

Hi! I created a merge request for this.

kimberlly_amaral’s picture

kimberlly_amaral commented
Assigned: Unassigned » kimberlly_amaral

I'll review that.

kimberlly_amaral’s picture

kimberlly_amaral commented
Assigned: kimberlly_amaral » Unassigned
Status: Needs review » Reviewed & tested by the community

I reviewed the changes and I found no errors.

cmlara’s picture

cmlara
he/him
commented
Status: Reviewed & tested by the community » Needs work

Provided comments in the MR.

larisse’s picture

larisse commented
Status: Needs work » Needs review
cmlara’s picture

cmlara
he/him
commented

Minor nit on language, however otherwise from a technical standpoint it looks good.

For discussion:
Realizing the main project page says ">=8.8.3 || ^9" so there was contrary to my original post an implication that it would cover 8.8 as well

However as noted in my first post I believe since we never got to beta on 3.x before D8 EOL we should still make this branch D9 only.

  • cmlara committed 0470775 on 3.x authored by larisse 
    Issue #3272169 by larisse: Set minimum Drupal version to D9
cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Fixed

Looks good to me! Thank you for working through this.

Merged into dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.