Closed (fixed)
Project:
Designs
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Mar 2022 at 04:43 UTC
Updated:
26 Mar 2022 at 17:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rromore commentedAttaching a patch which does uses the entities view builder to render the entity. Not sure if this needs to be done for the other submodules as well.
Comment #3
rromore commentedComment #4
rhys commentedI like the principle of this as a solution (although I don't think I've tried the combination you're currently using). Since this getMarkup() functionality is used in a few places, I'm going to be separating it out into a helper class, and ensuring it's used in those places.
My greatest concern is that I've not yet written enough tests (I've been building this module for another project). That aside, I'm fairly confident this won't break existing rendering process (but it's really hard to known without comprehensive test coverage).
Comment #6
rhys commentedComment #7
rhys commented