Problem/Motivation

See #3260857-36: Expand SourceEditingRedundantTagsConstraintValidator to also check attributes and attribute values.

Made possible by #3231328: SmartDefaultSettings should select the CKE5 plugin that minimizes creation of HTML restriction supersets.

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

None.

API changes

TBD

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#8 3271179-8.patch13.89 KBwim leers
#7 3271179-7.patch13.88 KBwim leers
#7 3271179-7-do-not-test.patch11.27 KBwim leers
#6 3271179-6.patch13.86 KBwim leers
#6 3271179-6-do-not-test.patch11.25 KBwim leers
#3 3271179-3-do-not-test.patch10.67 KBwim leers
#3 interdiff.txt10.98 KBwim leers
#2 3271179-2-do-not-test.patch3.76 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 3271179-2-do-not-test.patch3.76 KB

PoC. This applies on top of #3260857-39: Expand SourceEditingRedundantTagsConstraintValidator to also check attributes and attribute values. It passes tests.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff.txt10.98 KB
new 3271179-3-do-not-test.patch10.67 KB

Further developed PoC. This does not pass tests, but passes several of them; all of the critical foundations are present already.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Update SourceEditingRedundantTagsConstraintValidator to reuse SmartDefaultSettings » [PP-1] Update SourceEditingRedundantTagsConstraintValidator to reuse SmartDefaultSettings
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Postponed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-1] Update SourceEditingRedundantTagsConstraintValidator to reuse SmartDefaultSettings » Update SourceEditingRedundantTagsConstraintValidator to reuse SmartDefaultSettings
Status: Postponed » Needs review
Related issues: +#3231334: Global attributes (<* lang> and <* dir="ltr rtl">): validation + support (fix data loss)
StatusFileSize
new 3271179-6-do-not-test.patch11.25 KB
new 3271179-6.patch13.86 KB

#3260857: Expand SourceEditingRedundantTagsConstraintValidator to also check attributes and attribute values landed a long time ago. Unpostponing.

But #3231334: Global attributes (<* lang> and <* dir="ltr rtl">): validation + support (fix data loss) conflicted heavily with this.

Rebased. The do-not-test patch is the clean patch, the one that will be tested is the same, but just restricted to CKE5 tests only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 3271179-7-do-not-test.patch11.27 KB
new 3271179-7.patch13.88 KB

I don't know what happened in #6, but it was extremely frustratingly very broken 😬 So I had to rebase this again.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 3271179-8.patch13.89 KB

Bypass phpcs. I just want some test results.

Status: Needs review » Needs work

The last submitted patch, 8: 3271179-8.patch, failed testing. View results

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.