Problem/Motivation

Core tests outside of Color module install the color module. These need to be modified to maintain test coverage and possible move of tests to Color.

At least these files need to be updated.
\Drupal\Tests\field_ui\Kernel\EntityDisplayTest
\Drupal\Tests\system\Kernel\Extension\ModuleHandlerTest
\Drupal\Tests\system\Functional\Module\DependencyTest
\Drupal\Tests\help\Functional\HelpTest

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3270940-3.patch13.96 KBquietone
#3 interdiff-2-3.txt3.44 KBquietone
#2 3270940-2.patch10.83 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 3270940-2.patch10.83 KB

This has a change to module_test,module, which uses color, so more tests may break.

quietone’s picture

quietone commented
StatusFileSize
new interdiff-2-3.txt3.44 KB
new 3270940-3.patch13.96 KB

Uploaded the wrong patch, that is wrong for EntityDisplayTest.php. This adds changes to field_test module.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

It might be worth a follow-up to make these tests use test modules instead of real ones, but looks good otherwise.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 25d335d5cd to 10.0.x and 5883174087 to 9.4.x and 48cc607d48 to 9.3.x. Thanks!

Backported to 9.3.x to keep tests aligned.

  • alexpott committed 25d335d on 10.0.x 
    Issue #3270940 by quietone: Move all non migration Color tests to the...

  • alexpott committed 5883174 on 9.4.x 
    Issue #3270940 by quietone: Move all non migration Color tests to the...

  • alexpott committed 48cc607 on 9.3.x 
    Issue #3270940 by quietone: Move all non migration Color tests to the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.