Problem/Motivation

- Module is throwing a Fatal error:
Fatal error: Allowed memory size of X bytes exhausted (tried to allocate Ybytes) in /app/vendor/guzzlehttp/psr7/src/Stream.php on line 228

Steps to reproduce

1- Install the module: composer require 'drupal/msacr:^1.0@alpha'
2 - Access the report page: /admin/reports/module-security-advisory-coverage-report

Proposed resolution

- Implement the modules data check with Drupal's batch

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork msacr-3269884

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

barone created an issue. See original summary.

chris burge’s picture

+1 on this. I tested this with a 4GB PHP memory limit on a site with only a handful of modules enabled and ran into this error.

Take a look at Drupal\update\UpdateManager and Drupal\update\Controller\UpdateController.

I think the code in Drupal\msacr\Controller\ReportController could be substantially replaced by piggybacking on core's Update Manager module. It's already pulling a list of extensions from D.O. That data includes the security coverage for extensions.

chris burge’s picture

Priority: Normal » Major

nicrodgers made their first commit to this issue’s fork.

nicrodgers’s picture

Version: 1.0.0-alpha2 » 1.0.x-dev
Status: Active » Needs review
Issue tags: -

Great idea. I've implemented piggybacking on core's update module where available. It should fallback to doing it itself if Update is not enabled.

vinodhini.e’s picture

Hi, Tested this module on Drupal 10.5.1 and encountered an issue where the report page was not accessible.

Before applying the patch
Unable to access the report page due to a fatal error.

After applying MR #5:
The issue is resolved, and the report page is now loading correctly. Thanks.

nicrodgers’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.