Problem/Motivation

Configuration supplied with the module , config/install/advanced_form.advancedformsettings.yml ,is useless and unused.
Module configuration is actually stored in advancedform.advancedformsettings .

Steps to reproduce

This will result in:

Configuration advanced_form.advancedformsettings depends on the advanced_form extension that will not be installed after import. in Drupal\Core\Config\ConfigImporter->validate() (line 750 of /builds/yaGdakh4/0/xxx/yyy/web/core/lib/Drupal/Core/Config/ConfigImporter.php).
In ConfigImportCommands.php line 360:

The import failed due to the following reasons: Configuration advanced_form.advancedformsettings depends on the advanced_form extension that will not be installed after import.

Proposed resolution

  • Remove config/install/advanced_form.advancedformsettings.yml
  • Rename advancedform.advancedformsettings to advancedform.settings

Remaining tasks

  • [x] Correct initial configuration state
  • [ ] Implement post update hook to move existing settings
  • [ ] Review
  • [ ] Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 advancedform-3269792-2.patch1.21 KBrosk0

Issue fork advancedform-3269792

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

RoSk0 created an issue. See original summary.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: rosk0 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new advancedform-3269792-2.patch1.21 KB

Patch

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes

Patch does not remove invalid config/install yaml.

(This was addressed in MR to #3230827: Test fixes for 2.x)

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes

xurizaemon opened merge request !4

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Looks like #3 was addressed via #3230827: Test fixes for 2.x.

  • xurizaemon committed 3339acd on 3269792-config-cleanup authored by RoSk0 
    Issue #3269792 by RoSk0: Clean up configuration
  • xurizaemon committed b403b5c on 3269792-config-cleanup
    Issue #3269792: Consistent paths, routing
  • xurizaemon committed e4ddde8 on 3269792-config-cleanup
    Issue #3269792: Coding standards
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes

  • xurizaemon committed 3339acd on 3269792-config-cleanup authored by RoSk0 
    Issue #3269792 by RoSk0: Clean up configuration
  • xurizaemon committed b403b5c on 3269792-config-cleanup
    Issue #3269792: Consistent paths, routing
  • xurizaemon committed e4ddde8 on 3269792-config-cleanup
    Issue #3269792: Coding standards
  • xurizaemon committed 9557307 on 3269792-config-cleanup
    Issue #3269792: Update hook

ericgsmith made their first commit to this issue’s fork.

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Fixed

While config appears to have been fixed outside of this MR a while ago the update from advancedformsettings to settings is still a good cleanup and makes sense.

Rebased the MR + fixed docblock for the update function looks good to me

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.