Problem/Motivation

Checkboxes cannot be required input fields due to...well...the nature of checkboxes. If they're marked required, they're always TRUE. Checkboxes are useful for recalculating shipments during checkout.

Steps to reproduce

Add a checkbox to a shipping profile form...it will not recalculate shipping if modified.

Proposed resolution

Add checkbox support to shipping_checkout.js file.

Remaining tasks

See MR

CommentFileSizeAuthor
#4 3269202-4.patch1.38 KBjsacksick

Issue fork commerce_shipping-3269202

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexandersluiter created an issue. See original summary.

alexandersluiter opened merge request !10

jsacksick’s picture

jsacksick commented

The es6 version of the JS needs to be modified, and then the "regular" JS is generated using yarn build:js.

So basically, yarn setup and then yarn build:js.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
StatusFileSize
new 3269202-4.patch1.38 KB

This even simpler change should do the trick.

  • jsacksick committed a193d3d on 8.x-2.x 
    Issue #3269202 by alexandersluiter, jsacksick: Add Checkboxes to...
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.