Reimplement show modal on scroll to height

I'm testing that

Isn't working for me.

I put value: 50%

the modal is saved

But when I open again the value there is only "50" without "%"

so is considering pixels and not percent =/

Continue not working for me =/

For you it's working with 50% on that field?

I'll try to look into that.

Fixed the scroll problem based on scroll offset.

Now any offset type work from 0% to 100% scroll.

fixed the merge conflicts,

If the entire page is displayed on the screen (no scroll possibility), the modal is not displayed.

Made the purposed change on #11, and now it checks if that page has a scrollbar, if not, then shows the modal automatically.

Also fixed the merge problem.

Hi!

I will review.

- I confirm that "Height Offset" field is now considering pixels and percent values;

- The modal is displayed to entire pages (with no scroll possibility) as well;

- However, the modal appears twice if there's just a little space to scroll.

E.g., in a fresh installation of drupal with only the user "admin" registered, there is a scroll space of approximately 50px in the /admin/people page (in my monitor). In these cases, the modal appears twice (once when /admin/people get ready and another when scrolling).

Thanks @lucassc, added a return to prevent the modal from appearing more than once.
Also changed the if statement comparing the document and window height.

-            if ($("body").height() <= $(window).height()) {
+            if ($(document).height() == $(window).height()) {
               modal.modal();
               $(document).off(namespace);
+              return;
             }

Looks good to me! Everything works.

I just fixed some coding standards errors introduced by the issue.

RTBC if no one else disagrees.

Amazing work! Thank you all!