Problem/Motivation

Under the "Harder" and "Hardest" section of the CKEditor Media Embed Plugin project page, step 4 says:

4. Run drush config-set ckeditor_media_embed.settings plugins_version_installed [INSTALLED VERSION OF PLUGINS]

But this setting is incorrect. It should be plugins_installed_version as can be seen in config/install/ckeditor_media_embed.settings.yml.

Proposed resolution

Change step 4 for "Harder" and "Hardest" on the project page to say:

4. Run drush config-set ckeditor_media_embed.settings plugins_installed_version [INSTALLED VERSION OF PLUGINS]

FWIW I didn't follow those steps exactly since I installed it with composer following the approach noted in this issue comment. I guess that's the unspeakably hardest level, LOL, but I expect it's a pretty common use case.

Issue fork ckeditor_media_embed-3268723

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amanire created an issue. See original summary.

amanire’s picture

amanire commented
Title: Incorrect plugins version variable specified on project page » Incorrect plugins version setting specified on project page
amanire’s picture

amanire commented
Title: Incorrect plugins version setting specified on project page » Incorrect installed plugins version setting specified on project page
kimberlly_amaral’s picture

kimberlly_amaral commented

I'll work on this.

kimberlly_amaral’s picture

kimberlly_amaral commented
Assigned: Unassigned » kimberlly_amaral
grndlvl’s picture

grndlvl commented

The documentation on the project page is actually correct, however, it would be trashed pretty easily :( looks like we have two different strings....

https://git.drupalcode.org/project/ckeditor_media_embed/-/blob/8.x-1.x/s...
https://git.drupalcode.org/project/ckeditor_media_embed/-/blob/8.x-1.x/s...

vs

https://git.drupalcode.org/project/ckeditor_media_embed/-/blob/8.x-1.x/c...

The code is actually looking at the former. I'll need to update the initial settings.yml file.

kimberlly_amaral’s picture

kimberlly_amaral commented
Assigned: kimberlly_amaral » Unassigned
amanire’s picture

amanire commented
Title: Incorrect installed plugins version setting specified on project page » Incorrect installed plugins version key in settings.yml
Category: Task » Bug report

Ah, good to know.

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Active » Closed (outdated)