Problem/Motivation

This is part of #3267247: [meta] Fix and re-enable tests skipped for random failures, for ContentPreviewToggleTest::testContentPreviewToggle().

See the parent issue for steps to reproduce/proposed resolution.

CommentFileSizeAuthor
#8 3268678-8.patch2.37 KBbnjmnm
#7 3268678-7.patch2.37 KBbnjmnm

Issue fork drupal-3268678

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bnjmnm made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review

bnjmnm opened merge request !2635

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

The MR runs the test 1200x

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new 3268678-7.patch2.37 KB

Patch without the 1200x for committing.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new 3268678-8.patch2.37 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Great! I remember writing OffCanvasTestTrait and if using it is all the fix we need, so much the better. RTBC once green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed dcf0fd3bf9 to 10.1.x and 3fb9459a72 to 10.0.x and b9f1240ce2 to 9.5.x. Thanks!
Committed 1074da8 and pushed to 9.4.x. Thanks!

  • alexpott committed dcf0fd3 on 10.1.x 
    Issue #3268678 by bnjmnm: [random test failure] Restore...

  • alexpott committed 3fb9459 on 10.0.x 
    Issue #3268678 by bnjmnm: [random test failure] Restore...
xjm’s picture

xjm
she/her
Primary language English
commented

Looking good! Queued a few more jobs. If something is a 1/1000 fail rate (which is still enough to disrupt core development), there's nearly a 1% chance that running the test 4800 times will not fail even if the fail is still present. Merely doubling that to 9600 makes the chance of not having a fail when a fail is present exponentially small.

Edit: Crosspost. I will watch this space to ensure the jobs pass. :P

  • alexpott committed b9f1240 on 9.5.x 
    Issue #3268678 by bnjmnm: [random test failure] Restore...

  • alexpott committed 1074da8 on 9.4.x 
    Issue #3268678 by bnjmnm: [random test failure] Restore...
xjm’s picture

xjm
she/her
Primary language English
commented

All the jobs are green. 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.