Problem/Motivation

The joyride library was deprecated in drupal 9.2, now we have to remove it.

Proposed resolution

Removes jquery.joyride from core.

Remaining tasks

  • Create a merge request
  • Review
  • Commit

API changes

The jQuery Joyride third-party JavaScript library has been removed as a core dependency.

Issue fork drupal-3268228

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

murilohp created an issue. See original summary.

murilohp opened merge request !1937

murilohp’s picture

murilohp commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks great

feuerwagen’s picture

feuerwagen
he/him
Primary language German
Location Bonn 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

Just a single nitpick in the changed comment, left a suggestion on the MR. Otherwise it's looking good to me as well.

murilohp’s picture

murilohp commented
Assigned: murilohp » Unassigned
Status: Needs work » Needs review

@Feuerwagen, thanks for bringing this up!! Moving back to NR.

feuerwagen’s picture

feuerwagen
he/him
Primary language German
Location Bonn 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Thx @murilohp, back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

I think joyride can be removed from the dev dependency section of core/package.json

murilohp’s picture

murilohp commented
Status: Needs work » Needs review

Thanks @alexpott, I executed this command: yarn remove joyride inside the core folder, I think that's it.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Parent issue: » #3238507: Drupal 10 JavaScript dependency plan
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Drupal 10
feuerwagen’s picture

feuerwagen
he/him
Primary language German
Location Bonn 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Confirmed that @alexpott's feedback is addressed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 09597b7 and pushed to 10.0.x. Thanks!

  • alexpott committed 09597b7 on 10.0.x 
    Issue #3268228 by murilohp, Feuerwagen: Remove Jquery joyride

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Issue tags: +10.0.0 release notes