DBLogResource (with a capital B) should be renamed to DbLogResource (with a lower case b).

Because of our coding standards.
Because all the other classes in the dblog module use the correct casing.

IMO this is highly unlikely to affect anyone - core doesn't even use this resource. This is a plugin which will be discovered by the plugin manager via its annotation, not by its class name.

CommentFileSizeAuthor
#2 3268077-2-db-log-resource.patch1.21 KBtr

Comments

TR created an issue. See original summary.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 3268077-2-db-log-resource.patch1.21 KB
tr’s picture

tr commented
Related issues: +#3268078: DBLogResource is no longer being tested

Status: Needs review » Needs work

The last submitted patch, 2: 3268077-2-db-log-resource.patch, failed testing. View results

tr’s picture

tr commented
Status: Needs work » Needs review

Test fail is the LayoutBuilder FunctionalJavascript test which is causing lots of random fails in core right now and is not related to this issue.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Needs work
Issue tags: +Needs change record

Looks good to me @TR. But let's add a change record to document this change.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
Issue tags: -Needs change record

Change record added: https://www.drupal.org/node/3313636

Patch looks good.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Reviewed & tested by the community

Thanks @TR, @BramDriesen. Looks good to me.

  • catch committed c22d2af on 10.1.x 
    Issue #3268077 by TR: Rename DBLogResource
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed c22d2af and pushed to 10.1.x. Thanks!

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

Thanks. I published the CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.