Problem/Motivation

Whilst working on #3264918: Update symfony/console to Symfony 6 I've discovered that the argument $root in $data = $this->provideTemplateCreateProject($root); is unneeded, since that method doesn't require any parameters.

Proposed resolution

- Remove argument $root in MR
- Review
- Commit
- Move along, nothing to see here.

Issue fork drupal-3267900

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !1929

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PHPStan-1

PHPStan level 1 will find all these for us - this was added to the baseline in #3190406: Update PHPStan to level 1

  • catch committed ca515e5 on 10.0.x 
    Issue #3267900 by Spokje, longwave: Unneeded argument $root for ::...
  • catch committed ca9a0e1 on 10.1.x
    Issue #3267900 by Spokje, longwave: Unneeded argument $root for ::...
  • catch committed 4b8585a on 9.5.x
    Issue #3267900 by Spokje, longwave: Unneeded argument $root for ::...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.0.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, cherry-picked to 10.0.x and 9.5.x, thanks!

Spokje closed merge request !1929

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.