Problem/Motivation

We created a backwards-compatible jquery.cookie shim for Drupal 9 so that we could replace jquery.cookie with js-cookie, and tagged it as @deprecated in Drupal 10.0.0.

Proposed resolution

Removes jquery.cookie shim library, jquery.cookie shim tests, and removes library from js_cookie_test module

It should not be removed from any drupal7 database fixtures.

Remaining tasks

  • Create a merge request - DONE
  • Review merge request - DONE
  • ...

User interface changes

None

API changes

Removes deprecated backwards-compatible jquery.cookie shim.

Data model changes

None

Release notes snippet

Issue fork drupal-3267791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mradcliffe created an issue. See original summary.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Priority: Major » Normal

Changing priority to Normal. Whoops.

murilohp’s picture

murilohp commented
Assigned: Unassigned » murilohp

I'll help you with that!

xjm’s picture

xjm
she/her
Primary language English
commented

Removing credit until there is something in the MR. :) Weird UI behavior. Thanks for working on this!

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Critical

@mradcliffe, actually, this is a critical since it blocks 10.0.0-beta1. :)

murilohp opened merge request !1930

murilohp’s picture

murilohp commented
Assigned: murilohp » Unassigned
Status: Active » Needs review

I think that's it! Thanks! If you have any questions please let me know.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

This looks good to me. I checked for references and they only appear in joyride (which we don't use the functionality for). That library is planned to be removed in #3268228: Remove Jquery joyride.

I created a module that added core/js-cookie in hook_page_attachments(), enabled the module, refreshed the page, and confirmed `window.Cookies` was present.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs followup

The only usage of this was removed in #3268228: Remove Jquery joyride. I think we need a follow-up to deprecate and remove js-cookie too since it's not used anywhere in core after this is removed.

Committed 47f7945 and pushed to 10.0.x. Thanks!

  • lauriii committed 47f7945 on 10.0.x 
    Issue #3267791 by murilohp, mradcliffe: Remove deprecated jquery.cookie...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Raised the question about removing js-cookie on #3238507: Drupal 10 JavaScript dependency plan.

lauriii closed merge request !1930

xjm’s picture

xjm
she/her
Primary language English
commented

Hooray! Thanks for your work on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +10.0.0 release notes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -10.0.0 release notes

Oops, sorry for the noise; this is about the deprecated BC layer rather than the dependency itself, and as such it doesn't need an independent release notes mention.