Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3267644-2.patch6 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
commented
Assigned: danflanagan8 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3267644-2.patch6 KB

This one was much easier than anticipated, which is nice.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Reviewed & tested by the community

Since the patch just changes tests and selectors, going to RTBC.

+++ b/core/modules/block_content/tests/src/Functional/BlockContentListTest.php
@@ -65,11 +65,10 @@ public function testListing() {
-    // Check the contents of each row cell. The first cell contains the label,
-    // the second contains the machine name, and the third contains the
-    // operations list.
...
+    // Check the contents of the row. The first cell contains the label,
+    // and the second contains the operations list.

+1. This change fixes the comment, since there are only 2 cells.

  • xjm committed d9fb930 on 10.0.x 
    Issue #3267644 by danflanagan8, mglaman: Custom Block (block_content)...

  • xjm committed 435439a on 9.4.x 
    Issue #3267644 by danflanagan8, mglaman: Custom Block (block_content)...

  • xjm committed fc2f46b on 9.3.x 
    Issue #3267644 by danflanagan8, mglaman: Custom Block (block_content)...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.4.x-dev » 9.3.x-dev
Priority: Normal » Major
Status: Reviewed & tested by the community » Fixed

I spent way too much time trying to figure out why the comment in #3 gave the misinformation it did previously. There were a bunch of issues to improve UX related to block labels, titles, and machine names back around 2013-2014, but I wasn't able to find the specific change.

Then when I tested it I had way more cells than that... because Views was enabled. If Views is disabled, it does indeed fall back to a simple EntityListBuilder thingy with two cells, which matches the HTML output if I run the test locally.

Committed to 10.0.x, and cherry-picked to 9.4.x and 9.3.x as a patch-eligible test improvement. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.