Problem/Motivation

Support Drupal 10, as it says in the title.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

heddn created an issue. See original summary.

heddn’s picture

Status: Active » Needs review
StatusFileSize
new610 bytes

Let's see what happens.

heddn’s picture

StatusFileSize
new19.94 KB

There is probably some overlap here with #3255187: Drop support for Drupal 8. But the patches over there don't apply and it is easier to just start by responding to test failures/warnings. Let see if we get any closer with this.

berdir’s picture

+++ b/composer.json
@@ -9,6 +9,6 @@
   },
   "require": {
-    "drupal/core": "^8.8.2 || ^9"
+    "drupal/core": ">=9.2"
   }

See my and other comments in #3267143: Add a composer plugin that supports 'composer require-lenient' to support major version transitions :)

entity.module is a good example. It's fairly likely that if a major feature of entity.module really does make it into core, that we'll need to release a new major version. But we'll be unable to ever make the old releases incompatible with D11 or something, so people might end up installing old versions.

Granted, the feature use case is more likely to happen in D10.1/2 than D11, but still.

For duplicate, I guess you meant #3241541: Deprecate notices in tests for Event class (and also #3241538: Deprecate notices in tests for accessCheck).

But yes, the Drupal 8 issue could IMHO also be closed as a duplicate, I'm perfectly fine to just commit this to 8.x-1.x and drop D8 support there, as I wrote there. And half the plan of that other issue (releasing a last D8 compatible version) has now happened.

(That this has been so easy is also because quite a bit of work has already been done as part of the previous release).

heddn’s picture

StatusFileSize
new19.94 KB
new596 bytes

Switched to carrot instead.

berdir’s picture

Status: Needs review » Needs work
+++ b/composer.json
@@ -9,6 +9,6 @@
   "require": {
-    "drupal/core": ">=9.2"
+    "drupal/core": "^9.2"
   }
 }

Thanks, but if we do that, we need to explicitly mark it as D10 compatible too :) (Unlike the >=, which will already mark it as compatible with D11, D12...)

heddn’s picture

Status: Needs work » Needs review
StatusFileSize
new284 bytes
new19.95 KB
berdir’s picture

Status: Needs review » Needs work

info.yml too :)

heddn’s picture

Status: Needs work » Needs review
StatusFileSize
new19.95 KB
new326 bytes
berdir’s picture

+++ b/composer.json
@@ -9,6 +9,6 @@
   "require": {
-    "drupal/core": "^8.8.2 || ^9"
+    "drupal/core": "^9.2|^10.0@alpha"
   }
 }

is the @alpha really required? drupal/core will always be already present in a project, this will never need to actually require it. I didn't have to add that in other projects.

Other than, looks good to me and plan to commit soon-ish. Will also close the D8 issue in favor of this.

mglaman’s picture

I do not believe we need the @alpha as minimum stability is set on the root project. See https://semver.madewithlove.com/?package=drupal%2Fcore&constraint=^10.0&stability=dev

I know we had this annotation in Commerce. But this was to force upgrades when an RC was released in contrib. I don't think it's needed for Drupal core.

berdir’s picture

Status: Needs review » Fixed

Yeah, and my main point in #10 is that drupal/core is always going to be an explicit project root requirement, composer will never need to add drupal/core to a project because of us, we just need to comply with whatever the project has.

Committed without the @alpha.

  • Berdir committed cf5d149 on 8.x-1.x authored by heddn
    Issue #3267595 by heddn: Support Drupal 10
    

Berdir credited AardWolf.

Berdir credited TR.

berdir’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.