Problem/Motivation

In #3194084: Support functionality equivalent to ckeditor_stylesheets, a new ckeditor5-stylesheets theme configuration was created. It provides functionality similar to ckeditor_stylesheets, but exists as a separate settings as there are scenarios where a stylesheet that works well in CKEditor 4 won't necessarily work well in CKEditor 5.

Since this theme has ckeditor_stylesheets configured, it should get a ckeditor5-stylesheets setting. It may be possible to use the same stylesheets, but manual testing will be required to confirm the styling is desirable and doesn't have side effects. This is especially necessary as CKEditor5 stylesheets are not encapsulated in an <iframe>

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#16 issues-3267438-classy-ckeditor5-stylesheets-config.patch425 bytesshalini_jha
#10 classy-ckeditor5-stylesheets-3267438-10.patch343 bytesjrglasgow
#8 classy-ckeditor5-stylesheets-3267438-7.patch290 bytesjrglasgow
#6 3267438-6.patch369 bytesperarg

Issue fork classy-3267438

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Title: [PP-1] Add ckeditor5-stylesheets config » [PP-1] Add Classy ckeditor5-stylesheets config

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Project: Drupal core » Classy
Version: 10.1.x-dev » 1.0.x-dev
Component: Classy theme » Code

Classy has been removed from core, moving to the contrib project.

perarg’s picture

perarg commented
StatusFileSize
new 3267438-6.patch369 bytes

As first step in order to test it as @bnjmnm propose is to create a simple patch to change into ckeditor5_stylesheets and then get ready for manual tests

jrglasgow made their first commit to this issue’s fork.

jrglasgow’s picture

jrglasgow commented
StatusFileSize
new classy-ckeditor5-stylesheets-3267438-7.patch290 bytes

I have modified the patch to add an additional key "ckeditor5-stylesheets" instead of replacing the "ckeditor_stylesheets" key to make the theme compatible ith both drupal/ckeditor (CKEditor 4) and drupal/ckeditor5

jrglasgow opened merge request !2

jrglasgow’s picture

jrglasgow commented
Status: Active » Needs review
StatusFileSize
new classy-ckeditor5-stylesheets-3267438-10.patch343 bytes

make a change to the patch to make it patch more reliable

adamps’s picture

adamps commented
Title: [PP-1] Add Classy ckeditor5-stylesheets config » Add Classy ckeditor5-stylesheets config
Issue summary: View changes

No longer postponed as the blocking issue is now fixed.

siddharthjain’s picture

siddharthjain commented

Thanks @jrglasgow for the patch in #10. It applies applies smoothly.

nick hope’s picture

nick hope commented
Status: Needs review » Reviewed & tested by the community

#10 works for me with Classy 1.0.2 in D10.2.0. Setting to RTBC.

solideogloria’s picture

solideogloria commented

+1 RTBC. I've been using the patch a while.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Doubt this will ever get fixed as classy is deprecated. But the patch works for us as well as we work into removing classy as our base theme.

shalini_jha’s picture

shalini_jha commented
StatusFileSize
new issues-3267438-classy-ckeditor5-stylesheets-config.patch425 bytes

I have added this patch in Drupal 9.5.11.

solideogloria’s picture

solideogloria commented

@BramDriesen Core Classy is deprecated, but this is the contrib Classy module, which isn't deprecated. It's just contrib.

solideogloria’s picture

solideogloria commented

@shalini_jha That is for Core, not for this module.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

RE #17: Correct, but as it's not recommended for new projects, it does feel deprecated ;)

We do not recommend new projects use this theme, but this existing projects that depend on Classy may use this for Drupal 10+ and it should work no differently than if it were using the Drupal core Classy.

smustgrave closed merge request !2

  • smustgrave committed af448a4a on 2.0.x 
    Issue #3267438 by jrglasgow: Add Classy ckeditor5-stylesheets config
smustgrave’s picture

smustgrave commented
Version: 1.0.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

Will include with 2.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.