Problem/Motivation

Backbone 1.4.1 is out. Discovered in #3262573: Update our yarn dev dependencies to the extent allowed by current constraints one of our tests relies on the exact version so we need to bump Backbone and update the test at the same time.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3267339-2.patch129.18 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3267339-2.patch129.18 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

I re-created the patch locally by doing:

// Select backbone for update
yarn upgrade-interactive

// Update vendor
yarn run vendor-update

This creates the same patch as #2 apart from the test change. Nice. The changes from 1.4.0 to 1.4.1 look fine as well.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3267339-2.patch, failed testing. View results

ptomulik’s picture

ptomulik commented

Hi,
backbone 1.4.1 uses backbone-min.js.map (instead of backbone-min.map). Drupal only includes backbone-min.map. Drupal sites that use backbone 1.4.1 may report 404 error (in JS console). This may be fixed by adding backbone-min.js.map to ASSET_LIST of the> found in core/scripts/js/vendor-update.js.

nod_’s picture

nod_
Primary language French
Location Lille
commented

I see the two files in the backbone package, so I don't think we'll have a 404 https://unpkg.com/browse/backbone@1.4.1/

The new name is more in line with what is done by others so we should update vendor-update, not blocking though

(edit) just realized that what's important is that the sourceMappingURL points to the new file, so 404 indeed.

ptomulik’s picture

ptomulik commented

The 404 error was not a hypothesis. I'm actually seeing it on my site installation :)

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Closed (duplicate)

closed in favor of #3291283: Restore missing backbone-min.js.map, moving issue credit there.