Problem/Motivation

Layout Builder's FunctionalJavascript tests are consistently failing today on entirely unrelated patches:

https://www.drupal.org/pift-ci-job/2329991
https://www.drupal.org/pift-ci-job/2330001
https://www.drupal.org/pift-ci-job/2330007
https://www.drupal.org/pift-ci-job/2330008
https://www.drupal.org/pift-ci-job/2330029
https://www.drupal.org/pift-ci-job/2330033
https://www.drupal.org/pift-ci-job/2330034

Steps to reproduce

Proposed resolution

Add skips at the failure points for now.
Open a followup to investigate and revert.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3267124-2.patch3.54 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3267124-2.patch3.54 KB
catch’s picture

catch
he/him
Primary language English
commented

I think we could probably unskip once #3208793: Update Chrome container to use newer version is done, and then see what happens from there.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Okay - I'm not madly keen but the random fails are really disruptive. Let's revert once #3208793: Update Chrome container to use newer version lands.

  • catch committed 6e73953 on 10.0.x 
    Issue #3267124 by longwave, alexpott: Temporarily skip failing tests
  • catch committed 64d811c on 9.4.x
    Issue #3267124 by longwave, alexpott: Temporarily skip failing tests

(...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#3267247: [meta] Fix and re-enable tests skipped for random failures

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

We can backport this to 9.3.x if we really need to, but most tests are against the two development branches and 9.3.x is in freeze today, so just marking fixed for now.

Follow-up here: #3267247: [meta] Fix and re-enable tests skipped for random failures

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Random test failure

Unfortunately they all still have moderate to high fail rates following the Chromedriver update.

  • xjm committed 3e37843 on 9.3.x authored by catch 
    Issue #3267124 by longwave, alexpott: Temporarily skip failing tests

(...

  • xjm committed 4496349 on 9.2.x authored by catch 
    Issue #3267124 by longwave, alexpott: Temporarily skip failing tests

(...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 9.4.x-dev » 9.2.x-dev

Backported to 9.3.x and 9.2.x. Random fails are a huge frustration for private security tests, so we should always backport these fixes to the security-covered branch.

I checked over the list to make sure none of these tests were already fixed in other commits. Only CKE5 MediaLibraryTest and AjaxTest are already fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.