Problem/Motivation

* The field Container address (URL) should be of the type URL.
* Add some required fields: domain, site ID, datalayer. These should not be empty.

CommentFileSizeAuthor
#6 piwik_pro-config_form_fixes-3267013-6.patch3.55 KBjoshahubbers
#5 piwik_pro-config_form_fixes-3267013-5.patch2.28 KBjoshahubbers
#4 piwik_pro-config_form_fixes-3267013-4.patch1.83 KBjoshahubbers
#2 piwik_pro-url_field-3267013-2.patch692 bytesjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new piwik_pro-url_field-3267013-2.patch692 bytes

Patch fixes this.

joshahubbers’s picture

joshahubbers commented
Title: Field Container address (URL) should be of type url » Config form optimization
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new piwik_pro-config_form_fixes-3267013-4.patch1.83 KB
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new piwik_pro-config_form_fixes-3267013-5.patch2.28 KB
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new piwik_pro-config_form_fixes-3267013-6.patch3.55 KB

Found some more issues:
* missing t() in "Wrong data layer value"
* missing "use" statement.

joshahubbers’s picture

joshahubbers commented
Status: Active » Fixed

  • JoshaHubbers authored a8af26d on 1.0.x 
    Issue #3267013 by JoshaHubbers: Config form optimization

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.